mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: Jeff Garzik <jeff@garzik.org>
Cc: Andrew Morton <akpm@osdl.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MD: conditionalize some code
Date: Wed, 11 Oct 2006 09:53:11 +1000	[thread overview]
Message-ID: <17708.12903.712376.255113@cse.unsw.edu.au> (raw)
In-Reply-To: message from Jeff Garzik on Tuesday October 10

On Tuesday October 10, jeff@garzik.org wrote:
> 
> The autorun code is only used if this module is built into the static
> kernel image.  Adjust #ifdefs accordingly.
> 
> Signed-off-by: Jeff Garzik <jeff@garzik.org>

Acked-by: NeilBrown <neilb@suse.de>

Thanks,
NeilBrown

> 
> ---
> 
>  drivers/md/md.c               |    4 +++-
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 57fa64f..c75cdf9 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -3368,6 +3368,7 @@ out:
>  	return err;
>  }
>  
> +#ifndef MODULE
>  static void autorun_array(mddev_t *mddev)
>  {
>  	mdk_rdev_t *rdev;
> @@ -3482,6 +3483,7 @@ static void autorun_devices(int part)
>  	}
>  	printk(KERN_INFO "md: ... autorun DONE.\n");
>  }
> +#endif /* !MODULE */
>  
>  static int get_version(void __user * arg)
>  {
> @@ -5592,7 +5594,7 @@ static void autostart_arrays(int part)
>  	autorun_devices(part);
>  }
>  
> -#endif
> +#endif /* !MODULE */
>  
>  static __exit void md_exit(void)
>  {

  reply	other threads:[~2006-10-10 23:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-10 23:16 Jeff Garzik
2006-10-10 23:53 ` Neil Brown [this message]
2006-10-11 15:46   ` Steve Hindle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17708.12903.712376.255113@cse.unsw.edu.au \
    --to=neilb@suse.de \
    --cc=akpm@osdl.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®