mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Srinivasa Ds <srinivasa@in.ibm.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, torvalds@osdl.org
Subject: Re: [PATCH] 2.6.19-rc1: Fix build breakage with CONFIG_PPC32
Date: Mon, 16 Oct 2006 14:38:25 +1000	[thread overview]
Message-ID: <17715.3265.870339.317367@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <452F6838.6090605@in.ibm.com>

Srinivasa Ds writes:

> arch/powerpc/platforms/built-in.o: In function `flush_disable_caches':
> (.text+0x96d4): undefined reference to `low_cpu_die'
> ======================================================
> low_cpu_die() is defined under  CONFIG_PM || CONFIG_CPU_FREQ_PMAC  
> options ,but while calling this function ,no care has been to taken to 
> check these options. So please apply this fix,which solves the problem.

Nack.  The correct fix is to adjust the ifdefs in sleep.S to make
low_cpu_die available.  Otherwise it won't be possible to off-line
CPUs properly.

Paul.

  reply	other threads:[~2006-10-16  9:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-13 10:19 Srinivasa Ds
2006-10-16  4:38 ` Paul Mackerras [this message]
2006-10-18 12:04   ` Srinivasa Ds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17715.3265.870339.317367@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivasa@in.ibm.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®