mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Doug Anderson'" <dianders@chromium.org>
Cc: "'Thomas Abraham'" <thomas.abraham@linaro.org>,
	"'Stephen Warren'" <swarren@nvidia.com>,
	"'Changhwan Youn'" <chaos.youn@samsung.com>,
	"'Arnd Bergmann'" <arnd@arndb.de>,
	"'Olof Johansson'" <olof@lixom.net>,
	"'Simon Glass'" <sjg@chromium.org>,
	"'John Stultz'" <john.stultz@linaro.org>,
	"'Thomas Gleixner'" <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: RE: [PATCH] ARM: EXYNOS: Add missing semicolons in exynos_mct.c
Date: Mon, 25 Mar 2013 18:50:40 +0900	[thread overview]
Message-ID: <177201ce293e$35753cf0$a05fb6d0$%kim@samsung.com> (raw)
In-Reply-To: <1363967587-19154-1-git-send-email-dianders@chromium.org>

Doug Anderson wrote:
> 
> The CLOCKSOURCE_OF_DECLARE lines were added without a semicolon at the
> end.  On my system this causes a compile-time error that looks like:
> 
>  .../drivers/clocksource/exynos_mct.c:557:202: warning: comparison of
> distinct pointer types lacks a cast [enabled by default]
>  .../drivers/clocksource/exynos_mct.c:558:1: error: expected ',' or ';'
> before 'static'
> 
> The error didn't show up till now because there was an extra semicolon

Yeah.

> at end of the CLOCKSOURCE_OF_DECLARE definition that was removed by
> Arnd Bergmann in "clocksource: make CLOCKSOURCE_OF_DECLARE type safe"
> 
OK, thanks.

> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
>  drivers/clocksource/exynos_mct.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clocksource/exynos_mct.c
> b/drivers/clocksource/exynos_mct.c
> index 203ac05..106228d 100644
> --- a/drivers/clocksource/exynos_mct.c
> +++ b/drivers/clocksource/exynos_mct.c
> @@ -554,5 +554,5 @@ void __init mct_init(void)
>  	exynos4_clocksource_init();
>  	exynos4_clockevent_init();
>  }
> -CLOCKSOURCE_OF_DECLARE(exynos4210, "samsung,exynos4210-mct", mct_init)
> -CLOCKSOURCE_OF_DECLARE(exynos4412, "samsung,exynos4412-mct", mct_init)
> +CLOCKSOURCE_OF_DECLARE(exynos4210, "samsung,exynos4210-mct", mct_init);
> +CLOCKSOURCE_OF_DECLARE(exynos4412, "samsung,exynos4412-mct", mct_init);
> --
> 1.8.1.3

Applied, thanks.

- Kukjin


      reply	other threads:[~2013-03-25  9:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22 15:53 Doug Anderson
2013-03-25  9:50 ` Kukjin Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='177201ce293e$35753cf0$a05fb6d0$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=arnd@arndb.de \
    --cc=chaos.youn@samsung.com \
    --cc=dianders@chromium.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=sjg@chromium.org \
    --cc=swarren@nvidia.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®