From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 666542DEA74 for ; Thu, 26 Feb 2026 06:46:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772088402; cv=none; b=hdF1U4FLku0n5javbHUCYxHI91Ty553WuCKkK8Ide6df8k+cregIjvI/amPsfDekdY10RRWN4mjYkh1pcgCTAN463durIch7Q+3rqYYCiCRx0EorKHT0+U9qUNazQT/qhHz65CYXFnsVbkjoGc42Z8t+jl1U0sg6m98peaR14hc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772088402; c=relaxed/simple; bh=MHprEKGJ7TJgPffHT6hB4hfpFsv6f68mRCwU1c78FkA=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=hasBHHq1opr6kkU8gGmkJysusW5kX6opp90bLRoCNZg9QZu1EYQybIxys99lAfqfhsBuD1JN4wsoCLET30L2x0a5zeeyKo43ffIZynZHMYhV1F/BTjvDTjLYCzn8k8wDn8XzTCHG8eWy2mqx05xbjsi9I/9WOcNiW/ojkqBxceM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RzUw2lE6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JFnJYkvA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RzUw2lE6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JFnJYkvA" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61Q4VI2V3995344 for ; Thu, 26 Feb 2026 06:46:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HtW2bFRzDCHNDseCd5JWULZWJjDZJJs0SedB2d4noy4=; b=RzUw2lE6O0S/GDw6 x1tDc46Jr/9kjuoNhiTy2WNhpfLHRrh2nGDD59kj/i52bvXE3U5JGEtY0uS5iJUX cp5bxZm88mj4YILnU9VZtmT82AI579sfS79xQQDkHY5++1oP1+mZ+PrDci76Povn s4Syvu87xc0cmdUwfzQsXbXvYv8FTmjQK1TncyhVjXS+DTl+RXJKM9pN+BPAWMmg AEb3j/6cOgnDm/c4nTfxHx5jInHsuZzDLnh4W8wghEX3zbldubqudhyr1QQQB2ti 5DkXMD5oOLP5C0z/ytkq38k6/s0c+y78XuGRiaAokSxXgPK9nuAEXuF+YfOs4kXM M/QBGA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cj55st2te-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Feb 2026 06:46:40 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2add59d1a5aso4275665ad.3 for ; Wed, 25 Feb 2026 22:46:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772088400; x=1772693200; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HtW2bFRzDCHNDseCd5JWULZWJjDZJJs0SedB2d4noy4=; b=JFnJYkvAqHKJ+bbMgTPBx/VVc2xsmpfIfBIA+k5LGzNR20C7L6oXwAjY2u1pi+c/40 M2u0ICMXUMwSh+Qux8UMD0UR90ALHMscntv0KzIKgrg+GAVIXQ2eyBWIyzQm55DiQqEw LdHXWPngrwAavjJGz6YLdLmTJsC9y2DGMTddRrkZB1CQSf5o6CrVnJcqoA3aLh+g/Buw ZaaRKoQ3Sd00v1nqLYkCXokQy+Pm25trgxr4lkBJtKwY5OzDJ6qDp0ZguxV5jhaySxro H2zZkah1cjMK2ch9wwkL/6m/Wo3Lb762GTJSI5d6pJVo0fD3JuiQQ9lpuBXe/lPfiTvb OOdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772088400; x=1772693200; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HtW2bFRzDCHNDseCd5JWULZWJjDZJJs0SedB2d4noy4=; b=kjjAmDNvCwQdBNVRGLKZTAvoCCXO2HSDM5wY69iDaE+UFpe1JK++twM5y85TERoseX lKf0HGXPuH36pItfJaPm1heRIvGJyJtUuFYh3vNhM3U3qpUWriWj+RthlJIK9q3VwaEA cNEzT8btB1nGRAsJygSHQ5jzlzsGsHkp79uGXCjTQ9KeEWZwy0XStBnFTza8oHBMHn/6 eCJxsUifePI4BhrnOFJJqN8g2uX0Ww50TbxlcexsVVJHSlOzpEFqg9y5k2LC3Cs4h9E5 9t4El+z/YjEKI2YWygVqBEzqPDngbrQOgrgI5NLcoXF2TAg+ChC3M0wK5znOFXrF940l jqXQ== X-Forwarded-Encrypted: i=1; AJvYcCU+A/51sk1OXstnY7LZyZbAZuEuzU2EHVGHmcLCQaW5f/B9jmBt4QEmk4WLSqLHGlxqN81i0cGxGRXagrQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxwqp4/RcUfQTBkPu50zQqn1Rp/F+BnXpcWlf9uiGw3OJu8eEfs JYNdRFr7K50crQt9jjLvIWDZno96EHlOgfbtWw1H6o+65hZsbHC/CzOWARa21VGYAVe7hdaJVpl nKdyyhjkmT7Vp9qHY/kMw1s2CbXxQNHbl8N1vxmmP+4zvmOCqGXW6tc2LGgoMcTJtmQ8= X-Gm-Gg: ATEYQzxEOHnRptgajdDdp0ukLGIyrwE9IFxPS7oqKvCQHIpcqRRPjg2SQRtfIFORBSy eSMd2d0ErbQ0DgH4A2WyNQ6mNjvZLF7/VsIrB7hXiriudD+t3/uMTBdzZYwDr2uLT7MELvLbjXr sfETqwMVARar8EGx29aJzB/WYLydvmGoYlqGnh56nEmKPgtQ7FYzG4FtXK3OMi6bn2f11L22wd5 f0qKivo0/+ZsE5KG0wk23niCJtW7dbyty/9YjXMSDRrvKAVyUjqaOq2209KYIV9Oj91Pe+ZZFn+ eK1KB+BLL4oSbpzUWNFxQ7mFqq2AgL7RwX0mEuN90g+7Mh7g1TsmFsjAuKIWok0Yv7LIcNWpwMz WN5GehS8oaWH1yPVoCJpkOeE= X-Received: by 2002:a17:903:1a28:b0:2a0:de4f:c99 with SMTP id d9443c01a7336-2ae0305eecamr13245745ad.9.1772088399991; Wed, 25 Feb 2026 22:46:39 -0800 (PST) X-Received: by 2002:a17:903:1a28:b0:2a0:de4f:c99 with SMTP id d9443c01a7336-2ae0305eecamr13245475ad.9.1772088399484; Wed, 25 Feb 2026 22:46:39 -0800 (PST) Received: from [192.168.1.2] ([2401:4900:8fe5:3076:521d:50c0:367d:1d7b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb5db596sm14382225ad.35.2026.02.25.22.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 22:46:39 -0800 (PST) From: Manivannan Sadhasivam X-Google-Original-From: Manivannan Sadhasivam To: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Trent Piepho , Felix Gu Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org In-Reply-To: <20260124-pci_imx6-v2-1-acb8d5187683@gmail.com> References: <20260124-pci_imx6-v2-1-acb8d5187683@gmail.com> Subject: Re: [PATCH v2] PCI: imx6: Fix device node reference leak in imx_pcie_probe() Message-Id: <177208839386.15535.2535030930377494480.b4-ty@kernel.org> Date: Thu, 26 Feb 2026 12:16:33 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI2MDA1OCBTYWx0ZWRfX36F57x4OF4ht AeHgP5cERITSSRslaSwY0jM8lBJxQfHMf5gQpNSM7mIm1i96R4g8875i/OV7LaoIlGUM2MTCc/G g3ZzkNQmR0BHyznzz1k3agCjGK5FkXYGx/PMQocnix82Jf78WWKgfif3zGyriXxdAuBRON9ep3o DSmDno9rEOoRBuQhwFJHeiFYzAcyRxjt+euXwLJkbNju5I0ZaJJGOW4yS2/sUYtMdS7UiiLJu06 u5K5ezQH5xXV//CMg8qnk922Ke6nGU4Qpl5I1UAIyoe56U0oToO+wKTLZSg98DWyac6LdQSmhtb a0ZckMLSIdg0Yuz2x+VobOEw9sM6TNpP/QFj9Dmh79kUNwKV9yVqLn2jQx+kXCSXieXKigW7I3I Bku5mc8YhG/sAjmCqVLTF2wgo4JOVID08wWoYJ95Uf/uvOgSoQtUT6+gkFc0RKr5KoxyW/wZS0D RKUJy8eeYxNghE8/fOA== X-Proofpoint-GUID: 0z6Tk4sCb0KMrxn2KVp0uKMPgP7DTiTt X-Authority-Analysis: v=2.4 cv=JfGxbEKV c=1 sm=1 tr=0 ts=699fec50 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=vwxMJ2_kboZHlRSlzigA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: 0z6Tk4sCb0KMrxn2KVp0uKMPgP7DTiTt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_04,2026-02-25_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 bulkscore=0 suspectscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602260058 On Sat, 24 Jan 2026 23:42:45 +0800, Felix Gu wrote: > In imx_pcie_probe, np is obtained by of_parse_phandle() and must be > released when it's no longer needed. However, it doesn't release the > reference, which cuases a reference leak. > Fix this by using the __free(device_node) cleanup handler to release the > reference when it goes out of scope. > > > [...] Applied, thanks! [1/1] PCI: imx6: Fix device node reference leak in imx_pcie_probe() commit: 4836ad727486563370b213ef594d644d1bf85b8d Best regards, -- Manivannan Sadhasivam