From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0D4F3876A5 for ; Thu, 26 Feb 2026 07:20:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772090425; cv=none; b=eXqLxJ64Veetg7M6IhMY6nZvV+gNPoJ37hji8lku3yHLLtKO+FAPEeLWzlOA60xN7wU3FxuoKwpMZO3Ti+0JdQ/fvosiJjlZ4qwXm7b26GLGkFXkRM6bPM2SB70R+Ibmcyf/6fK0VllmAhoXgNJ+u31Bm3NleTLR4z0eH80T4pU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772090425; c=relaxed/simple; bh=NX1q0YIwIDIBod4zBMuz6cN7+56ua5lfz/lw6/gneYM=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=AAlGAgzW+r/wAjXcjEuliYDl3FalnQAXkfBLslKwqdev0+WEWURUhrY39g0rMG4pJwIfr2Q9XZmirkjTUYAvimJbcrGHvvCH0YU8ZsAh8jFEgl+4ubXuzpRiNW5IbCFYFMWq/8kNFwvsJ1YqTzPIQc9iP4CtEXX0WkhKEdgAr1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mTFWwLnc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WkYJIlv6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mTFWwLnc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WkYJIlv6" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61Q4UtCv3433649 for ; Thu, 26 Feb 2026 07:20:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uLoU54AaeC8QyX1TAF9QPbqh4JmXg8/ZE3JffoY4dU4=; b=mTFWwLnc5U+i6NVO M6O2v+0OnfAQ0pPDnIxu4PzA0fx4HefohDnQA+Y1jJOGeHmdjYvYkAvTeYhqZtH4 I2CcBMzOw+6hn2NOtnYIIamreKQ4fbBbp3vj7UYVdbvU7DOSiVWpH5ArQmxBP+G1 QwyofrdbBG/tGhpJQuh6AaT2VcoFtRIVR+ccI1fUm4lA4Bs9gz1kZ4vGPyKYci4e /tmQWwPWprrEzzhzezH4diezo/nK87ns2sHNZgIs2Uhxj2h6cnKUVL8aAKG1In9O 6zluPc0smlvHXypr8AB+0YUQJwOx+wEd6H6kRu5GWCioxH41B8MO4lPdieZdJWOA 3SRO5Q== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cjc0g8y38-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Feb 2026 07:20:23 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-358f8b01604so1688070a91.3 for ; Wed, 25 Feb 2026 23:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772090423; x=1772695223; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uLoU54AaeC8QyX1TAF9QPbqh4JmXg8/ZE3JffoY4dU4=; b=WkYJIlv61AY7/Qj8UHeMN2OGeU6Ck86ftEDBxBdW18orGCGz7LpbtR108WTuLwFCax EeLcj/BX4eVppADS83TObUj11frBztWW6FsVYZ59cHrm/J6vkhO/Tefw1bZ7xBzRPLGm 4l77E/vbR6gcp291QYRUgv7Jpj0+eJ6CCIScEIsxXVCg7ZqvB1btm35jGrdiltkN9q8u 4hpXEPMjFYUDrl4yUjPWlVg0+sw8FAxhhYcOoXjz1jhdfULwLSmFfsRiqPFpQtoI188c ji4a9FUiVroagDFzIApgXEyBtjnxsJEiOzXc+9eQlqBssowQDEsQqJJKzjxwfsfVJpPl xIVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772090423; x=1772695223; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uLoU54AaeC8QyX1TAF9QPbqh4JmXg8/ZE3JffoY4dU4=; b=syJmq5AO+aFILrhkf8fKml5VR2X95gIBu2b+fR585tk31UEygvMz7l9LTlfx3GJhD/ oV0U3DBHeuKXBCkCySmV4rugJVsSjMVdL3YL/F1N6dXTKeMrElPIFx9dKNQXuiFuHw9s N+oUuxOc3mxzOf3+sTqzfUBQ1EPrA8/Se3Bmzuv8szOdI8USQXoMUZobGBC6K7hBUc9J D7fIr6toITtBSWA7Nw30bEgptS9OILL1DFJZ9NIyex1H7PPtEo56fCbDJ3Bbcr+et/dP ee9FFVoKrDmJrOftqTWEZ8hhy3i0xKjol86hGcX0cEZpnqSYWPgS2usyRQZ/VYtyarqY 1aEQ== X-Forwarded-Encrypted: i=1; AJvYcCVE4LuChbhgiEsZtGstSZ9csYJy/6wnPhQt5y0ByFSRwltEHZgML/uMOjkexWsbMTzQQCTQgprs5WAci4Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyGsX/7Wmyi08MmoHArUm7uO7YysoVs8jtBmSBjm+g7RP9f/fCH 1A5Tu8m/dJwLX/OWhPaopMNbaA5Cp6qw0+3gAr0NwtyMGtyjPjqEF4AWJpKPQDyX6y4RH6qF/0h U5J4GBeTUvS/o7VlTAMnDEnQ37hPMIcdc22EDGLtCDgb/z9zXx3v/fxlxtbevS1adtRc= X-Gm-Gg: ATEYQzwv53n4pXwd4nz2VYbnmWJ3P8AauYOVIoajvX5uhVw3CHpLnv3p3t+zwSkwf3S wYTVDbfoSzXp1/apXZ/dBgGL1nx77rAyRm0tj/9WP2KGwHz+vPmV0J4T9kTFMfL1YA2W75z+ZOw 1MlEEv+ZqNGbj/L8Bkf61Kpeuw5QpchVxAjqIxKmbqzr8402Hl74iXCSQzYRTMPl/2bS3i8iSaA ryrPXrkrPkkv9UcpDU+3pZk3s3Dh6XTxdlosGsjOQZV9EfwlFvooQzSC2M45IBPXPwvT6UOdbFR 1recRVdSZurflA9uaTzfuR72mFbYC6F2ESpO7ZAxP4g2EDHa19hd7erQAz3nNVc9JBC+r/8lrkD F80+/LSkoAHoWl1fh83MDtUo= X-Received: by 2002:a17:90a:c2cf:b0:356:1edc:b6e with SMTP id 98e67ed59e1d1-35928a6c00amr2606808a91.8.1772090422583; Wed, 25 Feb 2026 23:20:22 -0800 (PST) X-Received: by 2002:a17:90a:c2cf:b0:356:1edc:b6e with SMTP id 98e67ed59e1d1-35928a6c00amr2606784a91.8.1772090421872; Wed, 25 Feb 2026 23:20:21 -0800 (PST) Received: from [192.168.1.2] ([2401:4900:8fe5:3076:521d:50c0:367d:1d7b]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3593dcc9c37sm1099694a91.8.2026.02.25.23.20.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 23:20:21 -0800 (PST) From: Manivannan Sadhasivam X-Google-Original-From: Manivannan Sadhasivam To: kwilczynski@kernel.org, Daniel Hodges Cc: kishon@kernel.org, bhelgaas@google.com, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org In-Reply-To: <20260206200529.10784-1-git@danielhodges.dev> References: <20260206200529.10784-1-git@danielhodges.dev> Subject: Re: [PATCH] PCI: epf-mhi: return 0 on success instead of positive jiffies Message-Id: <177209041798.86372.5318911333192648470.b4-ty@kernel.org> Date: Thu, 26 Feb 2026 12:50:17 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-Authority-Analysis: v=2.4 cv=XI49iAhE c=1 sm=1 tr=0 ts=699ff437 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=kPnkl4ryUGSNtqIeIPIA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI2MDA2NCBTYWx0ZWRfX8580VzSXvDRK R7W8Ni/J1VlAHAgyKMGsaMyXdVL3KkM0cUSLrpZDzdqL7ouEMS8hwmBMQa69jnVMjC+XAj3VGmQ sL6MkVn5O0MbOvNGN6X+CmWGxZBbwEOEB79QX4GBYwZAGlfapTT/AkoFHL9fpvuPMTshhdVqJDp kR6tJZQFPYqUFuZrI1/PbulmirKZYTk9dG3qN1AVui7yV6CWRitZ2FfO9frE4Q3H9cj6V6lz3jK oAiCIAuT/1A0lLlYqmdpvVmQ8x2hemQ9+gwPJQC7mtTinZ3WrjesZsJ6+P1YTswbzM6TFKuv6pQ bJBKNlBzrRKMbzxmXW69ZakKAJTSnaSXp6Tx7rORzioNPcY+V35l2MvJyLw3WVlTfGGQ5nSAblH UAXYpCdRVcnwrIFECcOmSMPT6H8SjTGt8gG0Yjf2E60goF5aM4haHO10KafygLL+Irmi2WrggJ0 YcRit2B73zmVf32aE3w== X-Proofpoint-ORIG-GUID: 5scN-ws1fROSNjjzjSSyOs7eGJPEeOfj X-Proofpoint-GUID: 5scN-ws1fROSNjjzjSSyOs7eGJPEeOfj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_04,2026-02-25_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 malwarescore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602260064 On Fri, 06 Feb 2026 15:05:29 -0500, Daniel Hodges wrote: > wait_for_completion_timeout() returns the number of jiffies remaining > on success (positive value) or 0 on timeout. The pci_epf_mhi_edma_read() > and pci_epf_mhi_edma_write() functions use the return value directly as > their own return value, only converting timeout (0) to -ETIMEDOUT. > > On success, they return the positive jiffies value. The callers in > drivers/bus/mhi/ep/ring.c check for errors with "if (ret < 0)" for > read_sync and "if (ret)" for write_sync. This causes write_sync success > cases to be incorrectly treated as errors since the positive jiffies > value is non-zero. > > [...] Applied, thanks! [1/1] PCI: epf-mhi: return 0 on success instead of positive jiffies commit: f6797680fe312ae6d32a773eb4d33400f24555c2 Best regards, -- Manivannan Sadhasivam