From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9113438FFF for ; Fri, 27 Feb 2026 15:25:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772205912; cv=none; b=E5t5Ywpfk3nIp2MGvRv5XEuKtZStEELfMl47AW+oqBkahzNNnQMzPIolqwql2JESNWfNcfhs6thlCkPyWUbNNaJwIRHTQx0Ap+kpPnFDJKWBSkdPalVr/4VRGG1h3hr45wkk/PFBwhXQZOu8EsFQlp/aBOphtCR8PEZiJ3//qB4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772205912; c=relaxed/simple; bh=ZL8EJPW0zLlMdvTaNP5yKmV/KVX4aXFG/etNpJF8r6M=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=eUpPIbl3M+UfgGkARxPaW0NwzF81NuZxpkwwOI+EUr5Fl/JROGiZB5kSJl7BSg4KXPPJtf70N25EuFfLzWli+N1Vq6alCh3RSYHhU/Sn18KK6yzCUhyfCk+mb14WxsLFTd0Bfe2tf4/UkIt0EzQjubVh+mqgJTvaaz+PYwquYqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Um3zw8y6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Um3zw8y6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CF6CC116C6; Fri, 27 Feb 2026 15:25:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772205911; bh=ZL8EJPW0zLlMdvTaNP5yKmV/KVX4aXFG/etNpJF8r6M=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=Um3zw8y6X7t3uRdtrfB6FoGYZFqMGJ2AFf8amanFdGs9bcV16BdfpOoCEzQ4e0zt8 yFeLsoLNk+t24zVJScB9AGGr2tJVA6Oh28cprl7/56uMS/1gGE5j/LQjIRXJeCIil/ C5km3Jnsx58g8MVEiml6CK6axUnhsfLKS9SU74bNR30q3VabGRqAa9E3Mi4E/wD0xo 1/5Avs+I69pdOoNajz8LOGVa3XCJxQEv+rrIfbYahKtdDo4jN7GvJvkG1wI8YM57jJ TXnMURihF2vnXwbBws4YqVCdYVSK10mjbjmYG44ppcq7K8aAjcWEY3OHw84hz9C9Vs x1jjNnofh3A1w== From: Vinod Koul To: linux-phy@lists.infradead.org, Vladimir Oltean Cc: Neil Armstrong , Ioana Ciornei , linux-kernel@vger.kernel.org In-Reply-To: <20260226182853.1103616-1-vladimir.oltean@nxp.com> References: <20260226182853.1103616-1-vladimir.oltean@nxp.com> Subject: Re: [PATCH phy-fixes] phy: lynx-28g: skip CDR lock workaround for lanes disabled in the device tree Message-Id: <177220591001.320398.14824622688771745554.b4-ty@kernel.org> Date: Fri, 27 Feb 2026 20:55:10 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13.0 On Thu, 26 Feb 2026 20:28:53 +0200, Vladimir Oltean wrote: > The blamed commit introduced support for specifying individual lanes as > OF nodes in the device, and these can have status = "disabled". > > When that happens, for_each_available_child_of_node() skips them and > lynx_28g_probe_lane() -> devm_phy_create() is not called, so lane->phy > will be NULL. Yet it will be dereferenced in lynx_28g_cdr_lock_check(), > resulting in a crash. > > [...] Applied, thanks! [1/1] phy: lynx-28g: skip CDR lock workaround for lanes disabled in the device tree commit: a258d843a3e4cb687da19437f8f81fee55ad7d35 Best regards, -- ~Vinod