From: Vinod Koul <vkoul@kernel.org>
To: Sven Peter <sven@kernel.org>, Neal Gompa <neal@gompa.dev>,
Neil Armstrong <neil.armstrong@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Janne Grunau <j@jannau.net>
Cc: asahi@lists.linux.dev, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Dan Carpenter <dan.carpenter@linaro.org>,
Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH phy-next v2] phy: apple: apple: Use local variable for ioremap return value
Date: Fri, 27 Feb 2026 20:59:26 +0530 [thread overview]
Message-ID: <177220616687.330302.14977409521915392205.b4-ty@kernel.org> (raw)
In-Reply-To: <20260215-phy-apple-resource-err-ptr-v2-1-e43c22453682@jannau.net>
On Sun, 15 Feb 2026 09:02:51 +0100, Janne Grunau wrote:
> The indirection through the resources array is unnecessarily complicated
> and resuling in using IS_ERR() and PTR_ERR() on a valid address. A local
> variable for the devm_ioremap_resource() return value is both easier to
> read and matches expectations when reading code.
>
>
Applied, thanks!
[1/1] phy: apple: apple: Use local variable for ioremap return value
commit: 290a35756aaef85bbe0527eaf451f533a61b5f6c
Best regards,
--
~Vinod
prev parent reply other threads:[~2026-02-27 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 8:02 Janne Grunau
2026-02-15 12:07 ` Sven Peter
2026-02-16 9:04 ` Vladimir Oltean
2026-02-27 15:29 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177220616687.330302.14977409521915392205.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=dan.carpenter@linaro.org \
--cc=j@jannau.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neal@gompa.dev \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=sven@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®