From: Paul Mackerras <paulus@samba.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Minor fixes to generic do_div
Date: Mon, 23 Oct 2006 17:49:03 +1000 [thread overview]
Message-ID: <17724.29679.520994.865570@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20061020033359.GR2602@parisc-linux.org>
Matthew Wilcox writes:
> * The semantics of do_div() are:
> *
> - * uint32_t do_div(uint64_t *n, uint32_t base)
> + * uint32_t do_div(uint64_t n, uint32_t base)
... or would be, if n were passed by reference. If you're going to
change the comment, I think you should say explicitly that n is
changed.
Paul.
prev parent reply other threads:[~2006-10-23 7:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-20 3:34 Matthew Wilcox
2006-10-20 4:59 ` Andrew Morton
2006-10-20 5:36 ` Matthew Wilcox
2006-10-20 5:49 ` Andrew Morton
2006-10-23 7:49 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17724.29679.520994.865570@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®