mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Abin Joseph <abin.joseph@amd.com>
Cc: git@amd.com, devicetree@vger.kernel.org,
	radhey.shyam.pandey@amd.com,  Frank.Li@kernel.org,
	dmaengine@vger.kernel.org, michal.simek@amd.com,
	 krzk+dt@kernel.org, linux-kernel@vger.kernel.org,
	conor+dt@kernel.org,  vkoul@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] dt-bindings: dma: xlnx,axi-dma: Convert to DT schema
Date: Tue, 03 Mar 2026 06:25:24 -0600	[thread overview]
Message-ID: <177254072483.2832550.13260823015526158791.robh@kernel.org> (raw)
In-Reply-To: <20260303114125.899850-1-abin.joseph@amd.com>


On Tue, 03 Mar 2026 17:11:24 +0530, Abin Joseph wrote:
> Convert the bindings document for Xilinx DMA.
> No changes to existing binding description.
> 
> Signed-off-by: Abin Joseph <abin.joseph@amd.com>
> ---
> 
> v3:
> -> Update the subject heading
> -> Remove examples for cdma and mcdma
> -> Fix the syntax issue for the clocks
> -> Squash the interrupt use case for axistream
> connected cases.
> -> Reorder the list as per the writing bindings
> 
> v2:
> -> Add examples for each compatible
> -> Remove the note added
> -> Use 'enum' rather than 'anyOf' and 'const'
> -> Wrap 80 char per line for descriptions
> -> Add dma-controller yaml reference
> -> Add -| for paragraph separation
> ->Remove labels from the examples
> 
> ---
>  .../bindings/dma/xilinx/xilinx_dma.txt        | 111 -------
>  .../bindings/dma/xilinx/xlnx,axi-dma.yaml     | 301 ++++++++++++++++++
>  2 files changed, 301 insertions(+), 111 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
>  create mode 100644 Documentation/devicetree/bindings/dma/xilinx/xlnx,axi-dma.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/xilinx/xlnx,axi-dma.yaml: allOf:1:then:properties:clock-names: {'items': [{'const': 's_axi_lite_aclk'}, {'const': 'm_axi_mm2s_aclk'}, {'const': 'm_axi_s2mm_aclk'}, {'const': 'm_axis_mm2s_aclk'}, {'const': 's_axis_s2mm_aclk'}], 'minItems': 1, 'maxItems': 5} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/xilinx/xlnx,axi-dma.yaml: allOf:3:then:properties:clock-names: {'items': [{'const': 's_axi_lite_aclk'}, {'const': 'm_axi_mm2s_aclk'}, {'const': 'm_axi_s2mm_aclk'}, {'const': 'm_axi_sg_aclk'}], 'minItems': 1, 'maxItems': 4} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260303114125.899850-1-abin.joseph@amd.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


      reply	other threads:[~2026-03-03 12:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 11:41 Abin Joseph
2026-03-03 12:25 ` Rob Herring (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177254072483.2832550.13260823015526158791.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=abin.joseph@amd.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=git@amd.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=radhey.shyam.pandey@amd.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®