From: Namhyung Kim <namhyung@kernel.org>
To: howardchu95@gmail.com, Ian Rogers <irogers@google.com>
Cc: acme@kernel.org, adrian.hunter@intel.com,
alexander.shishkin@linux.intel.com, james.clark@linaro.org,
jolsa@kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, mark.rutland@arm.com,
mingo@redhat.com, peterz@infradead.org, wangguangju@hygon.cn
Subject: Re: [PATCH v1] perf trace: Avoid an ERR_PTR in syscall_stats
Date: Tue, 03 Mar 2026 14:18:38 -0800 [thread overview]
Message-ID: <177257631862.2872307.8742084951961095200.b4-ty@kernel.org> (raw)
In-Reply-To: <20260302234515.565623-1-irogers@google.com>
On Mon, 02 Mar 2026 15:45:15 -0800, Ian Rogers wrote:
> hashmap__new may return an ERR_PTR and previously this would be
> assigned to syscall_stats meaning all use of syscall_stats needs to
> test for NULL (uninitialized) or an ERR_PTR. Given the only reason
> hashmap__new can fail is ENOMEM, just use NULL to indicate the
> allocation failure and avoid the code having to test for NULL and
> IS_ERR.
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
prev parent reply other threads:[~2026-03-03 22:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 12:22 [PATCH] perf trace: Fix IS_ERR() vs NULL check bug wangguangju
2026-02-26 15:50 ` Howard Chu
2026-02-26 16:32 ` Ian Rogers
2026-02-27 21:32 ` Namhyung Kim
2026-02-28 6:40 ` Ian Rogers
2026-02-28 7:06 ` Howard Chu
2026-03-02 23:45 ` [PATCH v1] perf trace: Avoid an ERR_PTR in syscall_stats Ian Rogers
2026-03-03 22:18 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177257631862.2872307.8742084951961095200.b4-ty@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=howardchu95@gmail.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=wangguangju@hygon.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®