From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02362255F2C for ; Thu, 5 Mar 2026 06:00:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772690409; cv=none; b=q71l8IUA/5vMcpdYsc85vU/5pO+8DyA6D2aiiGp6HoR/zXH8mYh7rcJRhoUWWRBJbv+qWUhGgLjzZ8sG6oV54VDMfzBfoWFwcNXuEMpq3PRbU/ACmwORTZDuvTk8N1euwdPcKg3xS6782f4KbHamLXsBo/OEYHevn+rpLC8viS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772690409; c=relaxed/simple; bh=fu2RJIxiGq5B6slToRtDN/OOlO0rZyjMDU5GoUvQeik=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=lG9RIhEpa6H7Ke0/0XiiD9xAYCOpWnRt6WHIxqX+Hywf8u5iJ+7pAr0/mnIxTv7n0Qib6xJKvwaS9pMR/DEM/KwRbDy5RZW/oc2whBytCu5okTqBEHAEJrThBIGUhH92EyXajou5xvFDvUWGUPR58d1TgtvDmy3pg71RQAQoSok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JeCJAnqw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HkqO5fgi; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JeCJAnqw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HkqO5fgi" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6251BgTD021013 for ; Thu, 5 Mar 2026 06:00:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CSPDd+Vt2mnahfvGcdf8DcFPCA8RiCUu8rYUql2KUJg=; b=JeCJAnqwfvyRUQSQ uKSSmc6ex8bVAbWco+H7XMkTEPf6+ux3CqGJCvJCcqdc09ezEHFRxlKSX0hv0ti5 0Ki9QZr/upWAoHibiBh9DNk6wE/v/K6VKa0rNjQbz6XgIILt8YVunzyIWmsiEBEV 8mLgUrZnh3kBySf4Nw1AQ4p3w/LFR45EgnohkivGlBJDQG3mpnS7l7rXnjLcPYVH tyIRLZSXbM3JE1DH1xAFVKmC9e6VVCEDBdW56YbhAX9jhBv3AVuoDIB9IAs+ST4v UJMWWszIz37UXTkIJPHxlSiM0wvvS5ea5sWqynpFD5cc6UK4bV/CeIDI5Cyep48j AKrl/A== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cpupthcrb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Mar 2026 06:00:07 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-359887aece0so4751593a91.1 for ; Wed, 04 Mar 2026 22:00:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772690406; x=1773295206; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CSPDd+Vt2mnahfvGcdf8DcFPCA8RiCUu8rYUql2KUJg=; b=HkqO5fgimvlmuUMMeIem5eCtUUn4LgKRr4bg+D14iizax30XSdpXWd4Owug1fTu4iB MNvxpy7r4IVChZxCjH7lt+Ku1pRLMcnhS4Ugms7Yys9ePCu/B3TRVoaQ3k/wrqfUThz1 9bXEGPtlK3+3RNAyiNVFnyRK7u+/iLrMjxn7005KoS63VJvDFzVktLFCPICW+wXknZtW WjRqaM0K4lZBCo7dzF+PUcL4sLPZjVYuFWLl9TswspZC0jQn6aRD6EHWLyKlFXySiWL7 q+bZCL1QuT7AMfScAMZTFxw+JlxEUjFg59ZUp4MT4VhE5IJULVZ6ZNvJV6f923mrWKTi O6cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772690406; x=1773295206; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CSPDd+Vt2mnahfvGcdf8DcFPCA8RiCUu8rYUql2KUJg=; b=HjaYEefpnG3E6j3aExm04s3wXAgZW8nFwx15aDLBvjaYqw3BeaRjSY6liuQZG8BgeI EcLJ06/Lop2Tox9DA3UT4igS0PbdSlXTKGu2qEe+SJXSGnSu0uIYadIEiTnlrb5A09s7 0scNhT5izekmxqxLdhWsxfha+OxLsI4/rgDMuimG2c9bYVDn7GpRPVbDEXtDX0rGM55i 5Y3xJqHR6UGInd8yAAxBwr8HmW5X8EjTLv3vHs5IikdO0Q47jwyHyNLmZk5IyIiTnotR HwWcAhgAkdm+11wGWiOz0Kw5ZQFkiuYiMFNHZgjxHRLLoGcSbvBZOAM9c4lXEO5SaUmD vcog== X-Forwarded-Encrypted: i=1; AJvYcCXjzqLZa3BDnzIkt7/fL5Wms8VmPMjaFU39UwFL350sLLw1Yf9U3dujTC/koXsHmZibiiKqXdeJ87+L7n4=@vger.kernel.org X-Gm-Message-State: AOJu0YzVZJsnNqbqUpGm3Gmknnwi7TeARBNerrN/DbisB21H0jDVNr7p Hyf3o/ZbK7lIiblGDLcaxtiskvkQH5ai5hQvIDmJc5bR4+r/bmnYK+Kp4+28l2X2qB8JrOo9eZ2 3DTPVHe0DWovbLiawwLiV/bdmGPOfWXAg7LdpkJSfv+RdzNEjeJAncbXc9XbCQ2IfhIk= X-Gm-Gg: ATEYQzxV0x0zyTzCaaBSp5LXaZMdIQDUpLvaKpINR9W+bXbY4+6NHLs2Z0QbrAMEXcB /TjhjNtrNXW6jHhx/xofnzUqLPcs/umrM9qMPKdVged+Bbrdk9holQy2auuMee0Jc27OMJGn5vf K/KpO+ZxfdsXAy80Z7TJ1MRzmppAtAZ835QLtuVQ+TumNhhzdMbm76J548qADjC/kQhgJIzsa9n TSMTk70+0CJIB7UCpyH1O6dQrXqMokCZKs0lx4XRJbZYm6gaBS3ve3geY61ojto8drNwKowXL82 At3AXAYpQvHatvswAc/V7TJ5cv/AYlD4XFavt+H9IBF78tGPZaWW8adKguR6fGrbUlglMlaofVq IorDH246xFo20RBqbo/33TUY= X-Received: by 2002:a17:90b:48d2:b0:359:1821:b4d4 with SMTP id 98e67ed59e1d1-359a6a9f7f6mr3804535a91.31.1772690406469; Wed, 04 Mar 2026 22:00:06 -0800 (PST) X-Received: by 2002:a17:90b:48d2:b0:359:1821:b4d4 with SMTP id 98e67ed59e1d1-359a6a9f7f6mr3804491a91.31.1772690405852; Wed, 04 Mar 2026 22:00:05 -0800 (PST) Received: from [192.168.1.2] ([2401:4900:88da:227d:1b86:2ae4:5dce:122e]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c738f543be4sm792964a12.0.2026.03.04.22.00.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 22:00:05 -0800 (PST) From: Manivannan Sadhasivam X-Google-Original-From: Manivannan Sadhasivam To: jingoohan1@gmail.com, lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com, Manivannan Sadhasivam Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Senchuan Zhang In-Reply-To: <20260226133951.296743-1-mani@kernel.org> References: <20260226133951.296743-1-mani@kernel.org> Subject: Re: [PATCH] PCI: dwc: Perform cleanup in the error path of dw_pcie_resume_noirq() Message-Id: <177269040188.13021.4911974718423067966.b4-ty@kernel.org> Date: Thu, 05 Mar 2026 11:30:01 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA1MDA0NSBTYWx0ZWRfXzVopYCVJaCD7 vnQ+s0OcWUyTT0bRjCTx4MxijD2o2RaAYRZteHmJhr6mTN/GUQMpp/7PygvQaqsRCzhEIJ8YmQV oc20VTZ7dU12gCIzSE16woF5y51zjvR+4k1cqeizWS5R5EQzBbTy9oFOcA3Gde+7vj9it1mTGxg qGxK/SFG2vaCQCNNR/VDxDSS7nslG0ySWQ0u/0+TB9HdJZGoYxuaJv5RMYlJhoYn0UOL/wvGWVO JxufonG/l2YsbwKuquNFmqub9zLMx2xID1Yz/lUWGdEFFut1kSmoVY6J1RI8AQOIurZOwPUGc0B QUPGOb4Ts7ZcNuZUw6FAT5Is1wUOgbF4jz+S46dSv2OskE9vZ8q40inEZrUXjjl8PWJz/fm+L2c O/cqGXsKFxK+ucC09NHkaW6h9QrjtIbjF0O6jdxv2Ik/d81Ad8VCbrY/yonQrKswEFPJt82Ea7a IvKl4kFOO8R8SizhbPg== X-Proofpoint-ORIG-GUID: X4BJJaP3OvWAC83opuQrisCXtSfm5ndf X-Authority-Analysis: v=2.4 cv=Ddsaa/tW c=1 sm=1 tr=0 ts=69a91be7 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=ojn154vqY31M59im7cEA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: X4BJJaP3OvWAC83opuQrisCXtSfm5ndf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-05_01,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 suspectscore=0 bulkscore=0 impostorscore=0 malwarescore=0 spamscore=0 adultscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603050045 On Thu, 26 Feb 2026 19:09:51 +0530, Manivannan Sadhasivam wrote: > If the dw_pcie_resume_noirq() API fails, it just returns the errno without > doing cleanup in the error path, leading to resource leak. > > So perform cleanup in the error path. > > Applied, thanks! [1/1] PCI: dwc: Perform cleanup in the error path of dw_pcie_resume_noirq() commit: cb5b15bf7a40d76b710fc5367d27f6897ecaa552 Best regards, -- Manivannan Sadhasivam