mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: dhowells@redhat.com, pc@manguebit.org,
	 Deepanshu Kartikey <kartikey406@gmail.com>
Cc: netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	 syzbot+7227db0fbac9f348dba0@syzkaller.appspotmail.com,
	 Deepanshu Kartikey <Kartikey406@gmail.com>
Subject: Re: [PATCH] netfs: Fix NULL pointer dereference in netfs_unbuffered_write() on retry
Date: Mon, 09 Mar 2026 10:22:20 +0100	[thread overview]
Message-ID: <177304814006.2374995.6514193767382546447.b4-ty@kernel.org> (raw)
In-Reply-To: <20260307043947.347092-1-kartikey406@gmail.com>

On Sat, 07 Mar 2026 10:09:47 +0530, Deepanshu Kartikey wrote:
> When a write subrequest is marked NETFS_SREQ_NEED_RETRY, the retry path
> in netfs_unbuffered_write() unconditionally calls stream->prepare_write()
> without checking if it is NULL.
> 
> Filesystems such as 9P do not set the prepare_write operation, so
> stream->prepare_write remains NULL. When get_user_pages() fails with
> -EFAULT and the subrequest is flagged for retry, this results in a NULL
> pointer dereference at fs/netfs/direct_write.c:189.
> 
> [...]

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] netfs: Fix NULL pointer dereference in netfs_unbuffered_write() on retry
      https://git.kernel.org/vfs/vfs/c/e9075e420a1e


      reply	other threads:[~2026-03-09  9:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-07  4:39 Deepanshu Kartikey
2026-03-09  9:22 ` Christian Brauner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177304814006.2374995.6514193767382546447.b4-ty@kernel.org \
    --to=brauner@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=kartikey406@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netfs@lists.linux.dev \
    --cc=pc@manguebit.org \
    --cc=syzbot+7227db0fbac9f348dba0@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®