mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Thomas Weißschuh" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: thomas.weissschuh@linutronix.de,
	Thomas Gleixner <tglx@kernel.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/vdso] selftests: vDSO: vdso_test_correctness: Add a test for time()
Date: Wed, 11 Mar 2026 09:31:05 -0000	[thread overview]
Message-ID: <177322146579.1647592.14707074796089546326.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260227-vdso-selftest-cleanups-v2-6-d84830fa8beb@linutronix.de>

The following commit has been merged into the timers/vdso branch of tip:

Commit-ID:     f7178f159b2a36d070fd43b0d751e4e4415ec39e
Gitweb:        https://git.kernel.org/tip/f7178f159b2a36d070fd43b0d751e4e4415ec39e
Author:        Thomas Weißschuh <thomas.weissschuh@linutronix.de>
AuthorDate:    Fri, 27 Feb 2026 07:46:01 +01:00
Committer:     Thomas Gleixner <tglx@kernel.org>
CommitterDate: Wed, 11 Mar 2026 10:27:40 +01:00

selftests: vDSO: vdso_test_correctness: Add a test for time()

Extend the test to also cover the time() function.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260227-vdso-selftest-cleanups-v2-6-d84830fa8beb@linutronix.de
---
 tools/testing/selftests/vDSO/vdso_test_correctness.c | 66 +++++++++++-
 1 file changed, 66 insertions(+)

diff --git a/tools/testing/selftests/vDSO/vdso_test_correctness.c b/tools/testing/selftests/vDSO/vdso_test_correctness.c
index a94ab4d..5c5a07d 100644
--- a/tools/testing/selftests/vDSO/vdso_test_correctness.c
+++ b/tools/testing/selftests/vDSO/vdso_test_correctness.c
@@ -55,6 +55,10 @@ typedef long (*vgtod_t)(struct timeval *tv, struct timezone *tz);
 
 vgtod_t vdso_gettimeofday;
 
+typedef time_t (*vtime_t)(__kernel_time_t *tloc);
+
+vtime_t vdso_time;
+
 typedef long (*getcpu_t)(unsigned *, unsigned *, void *);
 
 getcpu_t vgetcpu;
@@ -133,6 +137,10 @@ static void fill_function_pointers(void)
 	if (!vdso_gettimeofday)
 		printf("Warning: failed to find gettimeofday in vDSO\n");
 
+	vdso_time = (vtime_t)vdso_sym(version, name[2]);
+	if (!vdso_time)
+		printf("Warning: failed to find time in vDSO\n");
+
 }
 
 static long sys_getcpu(unsigned * cpu, unsigned * node,
@@ -156,6 +164,16 @@ static inline int sys_gettimeofday(struct timeval *tv, struct timezone *tz)
 	return syscall(__NR_gettimeofday, tv, tz);
 }
 
+static inline __kernel_old_time_t sys_time(__kernel_old_time_t *tloc)
+{
+#ifdef __NR_time
+	return syscall(__NR_time, tloc);
+#else
+	errno = ENOSYS;
+	return -1;
+#endif
+}
+
 static void test_getcpu(void)
 {
 	printf("[RUN]\tTesting getcpu...\n");
@@ -422,6 +440,53 @@ static void test_gettimeofday(void)
 	VDSO_CALL(vdso_gettimeofday, 2, &vdso, NULL);
 }
 
+static void test_time(void)
+{
+	__kernel_old_time_t start, end, vdso_ret, vdso_param;
+
+	if (!vdso_time)
+		return;
+
+	printf("[RUN]\tTesting time...\n");
+
+	if (sys_time(&start) < 0) {
+		if (errno == -ENOSYS) {
+			printf("[SKIP]\tNo time() support\n");
+		} else {
+			printf("[FAIL]\tsys_time failed (%d)\n", errno);
+			nerrs++;
+		}
+		return;
+	}
+
+	vdso_ret = VDSO_CALL(vdso_time, 1, &vdso_param);
+	end = sys_time(NULL);
+
+	if (vdso_ret < 0 || end < 0) {
+		printf("[FAIL]\tvDSO returned %d, syscall errno=%d\n",
+		       (int)vdso_ret, errno);
+		nerrs++;
+		return;
+	}
+
+	printf("\t%lld %lld %lld\n",
+	       (long long)start,
+	       (long long)vdso_ret,
+	       (long long)end);
+
+	if (vdso_ret != vdso_param) {
+		printf("[FAIL]\tinconsistent return values: %lld %lld\n",
+		       (long long)vdso_ret, (long long)vdso_param);
+		nerrs++;
+		return;
+	}
+
+	if (!(start <= vdso_ret) || !(vdso_ret <= end)) {
+		printf("[FAIL]\tTimes are out of sequence\n");
+		nerrs++;
+	}
+}
+
 int main(int argc, char **argv)
 {
 	version = versions[VDSO_VERSION];
@@ -432,6 +497,7 @@ int main(int argc, char **argv)
 	test_clock_gettime();
 	test_clock_gettime64();
 	test_gettimeofday();
+	test_time();
 
 	/*
 	 * Test getcpu() last so that, if something goes wrong setting affinity,

  reply	other threads:[~2026-03-11  9:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27  6:45 [PATCH v2 0/6] selftests: vDSO: Assorted cleanups and improvements Thomas Weißschuh
2026-02-27  6:45 ` [PATCH v2 1/6] Revert "selftests: vDSO: parse_vdso: Use UAPI headers instead of libc headers" Thomas Weißschuh
2026-03-11  9:31   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2026-03-11 14:51   ` tip-bot2 for Thomas Weißschuh
2026-02-27  6:45 ` [PATCH v2 2/6] selftests: vDSO: vdso_test_gettimeofday: Remove nolibc checks Thomas Weißschuh
2026-03-11  9:31   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2026-03-11 14:51   ` tip-bot2 for Thomas Weißschuh
2026-02-27  6:45 ` [PATCH v2 3/6] selftests: vDSO: vdso_test_correctness: Drop SYS_getcpu fallbacks Thomas Weißschuh
2026-03-11  9:31   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2026-03-11 14:51   ` tip-bot2 for Thomas Weißschuh
2026-02-27  6:45 ` [PATCH v2 4/6] selftests: vDSO: vdso_test_correctness: Handle different tv_usec types Thomas Weißschuh
2026-03-11  9:31   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2026-03-11 14:51   ` tip-bot2 for Thomas Weißschuh
2026-02-27  6:46 ` [PATCH v2 5/6] selftests: vDSO: vdso_test_correctness: Use facilities from parse_vdso.c Thomas Weißschuh
2026-03-11  9:31   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2026-03-11 14:51   ` tip-bot2 for Thomas Weißschuh
2026-02-27  6:46 ` [PATCH v2 6/6] selftests: vDSO: vdso_test_correctness: Add a test for time() Thomas Weißschuh
2026-03-11  9:31   ` tip-bot2 for Thomas Weißschuh [this message]
2026-03-11 14:51   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177322146579.1647592.14707074796089546326.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=tglx@kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®