From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 REPOST 3/8] staging: rtl8712: fix comment
Date: Wed, 5 Aug 2015 17:17:16 -0700 [thread overview]
Message-ID: <177329d196367479f5d4c89d9f4a5f844e563075.1438778593.git.stillcompiling@gmail.com> (raw)
In-Reply-To: <cover.1438778593.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438778593.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.5.0
next prev parent reply other threads:[~2015-08-06 0:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 0:17 [PATCH v4 REPOST 0/8] clean up wlan_bssdef.h Joshua Clayton
2015-08-06 0:17 ` [PATCH v4 REPOST 1/8] staging: rtl8712: fix buggy size calculation Joshua Clayton
2015-08-06 0:17 ` [PATCH v4 REPOST 2/8] staging: rtl8712: simplify " Joshua Clayton
2015-08-06 0:17 ` Joshua Clayton [this message]
2015-08-06 0:17 ` [PATCH v4 REPOST 4/8] staging: rtl8712: removed unused wrapper structs Joshua Clayton
2015-08-06 0:17 ` [PATCH v4 REPOST 5/8] staging: rtl8712: remove duplicate struct Joshua Clayton
2015-08-06 0:17 ` [PATCH v4 REPOST 6/8] staging: rtl8712: rename function Joshua Clayton
2015-08-06 0:17 ` [PATCH v4 REPOST 7/8] staging: rtl8712: remove typedefs Joshua Clayton
2015-08-06 0:17 ` [PATCH v4 REPOST 8/8] staging: rtl8712: change SupportedRates to rates Joshua Clayton
2015-08-06 8:06 ` [PATCH v4 REPOST 0/8] clean up wlan_bssdef.h Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177329d196367479f5d4c89d9f4a5f844e563075.1438778593.git.stillcompiling@gmail.com \
--to=stillcompiling@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nitinkuppelur@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®