From: Benjamin Tissoires <bentiss@kernel.org>
To: Jiri Kosina <jikos@kernel.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Lee Jones <lee@kernel.org>
Subject: Re: (subset) [RFC v3 1/2] HID: core: Mitigate potential OOB by removing bogus memset()
Date: Mon, 16 Mar 2026 16:59:52 +0100 [thread overview]
Message-ID: <177367679237.2580085.4886533819894692916.b4-ty@kernel.org> (raw)
In-Reply-To: <20260309145942.1496072-1-lee@kernel.org>
On Mon, 09 Mar 2026 14:59:29 +0000, Lee Jones wrote:
> The memset() in hid_report_raw_event() has the good intention of
> clearing out bogus data by zeroing the area from the end of the incoming
> data string to the assumed end of the buffer. However, as we have
> previously seen, doing so can easily result in OOB reads and writes in
> the subsequent thread of execution.
>
> The current suggestion from one of the HID maintainers is to remove the
> memset() and simply return if the incoming event buffer size is not
> large enough to fill the associated report.
>
> [...]
Applied, thanks!
[1/2] HID: core: Mitigate potential OOB by removing bogus memset()
commit: 0a3fe972a7cb1404f693d6f1711f32bc1d244b1c
Best regards,
--
Benjamin Tissoires <bentiss@kernel.org>
prev parent reply other threads:[~2026-03-16 16:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 14:59 Lee Jones
2026-03-09 14:59 ` [RFC v3 2/2] HID: core: Check to ensure report responses match the request Lee Jones
2026-03-16 15:28 ` Benjamin Tissoires
2026-03-17 9:20 ` Lee Jones
2026-03-17 14:52 ` Benjamin Tissoires
2026-03-16 15:14 ` [RFC v3 1/2] HID: core: Mitigate potential OOB by removing bogus memset() Lee Jones
2026-03-16 15:26 ` Benjamin Tissoires
2026-03-16 15:59 ` Benjamin Tissoires [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177367679237.2580085.4886533819894692916.b4-ty@kernel.org \
--to=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®