From: Carlos Maiolino <cem@kernel.org>
To: Dave Chinner <dchinner@redhat.com>, Yuto Ohnuki <ytohnuki@amazon.com>
Cc: "Darrick J . Wong" <darrick.wong@oracle.com>,
Brian Foster <bfoster@redhat.com>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/4] xfs: fix AIL push use-after-free during shutdown
Date: Wed, 18 Mar 2026 11:12:33 +0100 [thread overview]
Message-ID: <177382875345.271956.17498312779581645526.b4-ty@kernel.org> (raw)
In-Reply-To: <20260310183835.89827-6-ytohnuki@amazon.com>
On Tue, 10 Mar 2026 18:38:36 +0000, Yuto Ohnuki wrote:
> When a filesystem is shut down, background inode reclaim and the xfsaild
> can race to abort and free dirty inodes. Since commit 90c60e164012
> ("xfs: xfs_iflush() is no longer necessary"), xfs_inode_item_push() no
> longer holds ILOCK_SHARED while flushing, removing the protection that
> prevented the inode from being reclaimed during the flush.
>
> This results in use-after-free when dereferencing log items after
> iop_push() returns, or when reacquiring the AIL lock via lip->li_ailp.
>
> [...]
Applied to for-next, thanks!
[1/4] xfs: stop reclaim before pushing AIL during unmount
commit: 4f24a767e3d64a5f58c595b5c29b6063a201f1e3
[2/4] xfs: avoid dereferencing log items after push callbacks
commit: 79ef34ec0554ec04bdbafafbc9836423734e1bd6
[3/4] xfs: save ailp before dropping the AIL lock in push callbacks
commit: 394d70b86fae9fe865e7e6d9540b7696f73aa9b6
[4/4] xfs: refactor xfsaild_push loop into helper
commit: 7cac60947335f8d88a6390814840590a61134484
Best regards,
--
Carlos Maiolino <cem@kernel.org>
prev parent reply other threads:[~2026-03-18 10:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 18:38 Yuto Ohnuki
2026-03-10 18:38 ` [PATCH v4 1/4] xfs: stop reclaim before pushing AIL during unmount Yuto Ohnuki
2026-03-10 20:39 ` Darrick J. Wong
2026-03-10 18:38 ` [PATCH v4 2/4] xfs: avoid dereferencing log items after push callbacks Yuto Ohnuki
2026-03-10 20:40 ` Darrick J. Wong
2026-03-10 18:38 ` [PATCH v4 3/4] xfs: save ailp before dropping the AIL lock in " Yuto Ohnuki
2026-03-10 18:38 ` [PATCH v4 4/4] xfs: refactor xfsaild_push loop into helper Yuto Ohnuki
2026-03-10 20:40 ` Darrick J. Wong
2026-03-18 10:12 ` Carlos Maiolino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177382875345.271956.17498312779581645526.b4-ty@kernel.org \
--to=cem@kernel.org \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ytohnuki@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®