From: Jia Wang <wangjia@ultrarisc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: wangjia@ultrarisc.com, "Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Xincheng Zhang" <zhangxincheng@ultrarisc.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] dt-bindings: PCI: Add UltraRISC DP1000 PCIe controller
Date: Fri, 20 Mar 2026 14:15:03 +0800 [thread overview]
Message-ID: <177398730341.868832.396923232162447023.b4-reply@b4> (raw)
In-Reply-To: <733fff11-c670-42f9-812a-ad5a501491a1@kernel.org>
On 2026-03-16 11:05 +0100, Krzysztof Kozlowski wrote:
> On 16/03/2026 08:06, Jia Wang via B4 Relay wrote:
> > From: Jia Wang <wangjia@ultrarisc.com>
> >
> > Add UltraRISC DP1000 SoC PCIe controller devicetree bindings.
> >
> > Signed-off-by: Jia Wang <wangjia@ultrarisc.com>
> > ---
> > .../bindings/pci/ultrarisc,dp1000-pcie.yaml | 108 +++++++++++++++++++++
> > 1 file changed, 108 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/ultrarisc,dp1000-pcie.yaml b/Documentation/devicetree/bindings/pci/ultrarisc,dp1000-pcie.yaml
> > new file mode 100644
> > index 000000000000..b50ff98dd878
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pci/ultrarisc,dp1000-pcie.yaml
> > @@ -0,0 +1,108 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pci/ultrarisc,dp1000-pcie.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: UltraRISC DP1000 PCIe Host Controller
> > +
> > +description: |
> > + UltraRISC DP1000 SoC PCIe host controller is based on the DesignWare PCIe IP.
> > + This binding describes the UltraRISC specific extensions to the base DesignWare
> > + PCIe binding.
> > +
> > +maintainers:
> > + - Xincheng Zhang <zhangxincheng@ultrarisc.com>
> > + - Jia Wang <wangjia@ultrarisc.com>
> > +
> > +allOf:
> > + - $ref: /schemas/pci/pci-bus.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: ultrarisc,dp1000-pcie
> > +
> > + reg:
> > + - description: Data Bus Interface (DBI) registers.
> > + - description: PCIe configuration space region.
>
> Never tested. Test your patches before sending to avoid common mistakes.
> Several issues here are just duplicating known issue.
>
> Read also sashiko review of your code.
>
> https://sashiko.dev/#/patchset/20260316-ultrarisc-pcie-v1-0-ef2946ede698%40ultrarisc.com
>
Thanks for the review and the pointer.
I have checked the Sashiko report and will fix all issues in the next version.
> Best regards,
> Krzysztof
>
Best regards,
Jia
next prev parent reply other threads:[~2026-03-20 6:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 7:06 [PATCH 0/4] riscv: Add PCIe support for UltraRISC DP1000 SoC Jia Wang via B4 Relay
2026-03-16 7:06 ` [PATCH 1/4] riscv: add UltraRISC SoC family Kconfig support Jia Wang via B4 Relay
2026-03-16 14:39 ` Conor Dooley
2026-03-17 6:46 ` Jia Wang
2026-03-17 13:02 ` Conor Dooley
2026-03-19 9:28 ` Jia Wang
2026-03-16 7:06 ` [PATCH 2/4] MAINTAINERS: Add entry for the UltraRISC DP1000 PCIe controller driver and its DT binding Jia Wang via B4 Relay
2026-03-16 7:06 ` [PATCH 3/4] dt-bindings: PCI: Add UltraRISC DP1000 PCIe controller Jia Wang via B4 Relay
2026-03-16 8:21 ` Rob Herring (Arm)
2026-03-19 10:09 ` Jia Wang
2026-03-16 10:05 ` Krzysztof Kozlowski
2026-03-20 6:15 ` Jia Wang [this message]
2026-03-17 4:56 ` Yao Zi
2026-03-20 6:18 ` Jia Wang
2026-03-16 7:07 ` [PATCH 4/4] PCI: dwc: Add UltraRISC DP1000 PCIe rc driver Jia Wang via B4 Relay
2026-03-16 20:49 ` Bjorn Helgaas
2026-03-20 9:33 ` Jia Wang
2026-03-17 5:32 ` Yao Zi
2026-03-20 9:37 ` Jia Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177398730341.868832.396923232162447023.b4-reply@b4 \
--to=wangjia@ultrarisc.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=zhangxincheng@ultrarisc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®