From: Paul Mackerras <paulus@samba.org>
To: Christoph Raisch <RAISCH@de.ibm.com>
Cc: "Roland Dreier" <rdreier@cisco.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
openib-general@openib.org, openib-general-bounces@openib.org
Subject: Re: [openib-general] [PATCH 2.6.19 2/4] ehca: hcp_phyp.c: correct page mapping in 64k page mode
Date: Fri, 10 Nov 2006 19:46:10 +1100 [thread overview]
Message-ID: <17748.15442.906060.210242@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <OF75FFAC00.E43450CA-ONC1257222.002A402A-C1257222.002AB9BD@de.ibm.com>
Christoph Raisch writes:
> The patch is needed. We've seen it on the real system. We did fix it on the
> real system.
I disagree that the ioremap change is needed.
> ...and it conforms to theory... although theory is a bit confusing here.
>
> let me try to summarize:
> ioremap checks for 64k boundary (actually page boundary)
Actually, ioremap itself already does the calculations that your patch
adds - that is, it generates the offset within the page and the
physical address of the start of the page, does the mapping using the
latter, then adds on the offset to the virtual address of the page and
returns that.
Paul.
next prev parent reply other threads:[~2006-11-10 8:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-05 20:41 Hoang-Nam Nguyen
2006-11-07 19:25 ` Roland Dreier
2006-11-08 10:22 ` Christoph Raisch
2006-11-08 22:06 ` Roland Dreier
2006-11-09 6:36 ` Paul Mackerras
2006-11-09 21:58 ` Roland Dreier
2006-11-10 7:49 ` [openib-general] " Christoph Raisch
2006-11-10 8:46 ` Paul Mackerras [this message]
2006-11-13 16:39 ` Roland Dreier
2006-11-13 16:40 ` Christoph Raisch
2006-11-13 16:40 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17748.15442.906060.210242@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=RAISCH@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=openib-general-bounces@openib.org \
--cc=openib-general@openib.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®