From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09EC63A6EE7 for ; Mon, 30 Mar 2026 07:51:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774857097; cv=none; b=QyfQcSnIC6XTIQZbRNdHJZo9YzLF7btVYVb2lzBU1wGHli6QBV0ZHZmLWwGqCQ2btzeLUDmZOu+smPTTRMwl/4pNX5ku27dX8ehOG/zVVAIAHJrPq64Z2B3kT7OnQVBB7uvVgH4CMD5MaXA6Vx6wMF1vSukA9L51ghrm2lBgV+Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774857097; c=relaxed/simple; bh=Wtwyx+rHoNn/JRfhHP9pjHO4uK9/lBUP/VYjCAIasLQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=O0CS+E6YLojWA8GCfM7+2hV8k8wO7JJLoFyAUs61dkHzzn+QkpE8aox+AXx+3UATMwxeR+JKlTYe769BGiOjzhCGuBPHyhkwVJA7P3rUhUgglA+H84xXaj0PPi4hFYesUk6YodGpMAYAgfCuZ0JRh3DT8OcxjIyqnm9lz2TccZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f/X3cQoJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aTJJgPJb; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f/X3cQoJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aTJJgPJb" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62U455K9581066 for ; Mon, 30 Mar 2026 07:51:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yqoFzHrqxv2RFgrza41YChO6hXH6iktD/zgGiClPpPI=; b=f/X3cQoJzfSxaNNJ SslrptOyEa6kU/3sYL37JXfPf4H5sWE2gUK5ZdQmU66p8CP3ejEqYsAudbVz529Z OMMSvYzPf3GfpaYDprJSd+T7w5E8caRtrXX8Dg49H3k9VmDjer9OI/5ZLVZPtwk8 GqCVoStoethN1LcFwZShhFD0xHpSyhn+erawUAUBGUekzI/9Sg0F2ARJyNjGHZ8M uRCN7l6oVg98EUhQa0EWG1XlotJqKP5HNxoeW9xfZhzKui0pMSKG3a6KKKMxJcoT mifY0nmRti5xNYebm2qXbUVEIx8nzBQlJG2pCKn2jGleXPl7Qd97lC7388mAMFmO SoJoFw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d65xqn7jt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 07:51:34 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50b52a2d70cso125586551cf.3 for ; Mon, 30 Mar 2026 00:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774857094; x=1775461894; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yqoFzHrqxv2RFgrza41YChO6hXH6iktD/zgGiClPpPI=; b=aTJJgPJb2J7GAiDSkgufneruy8iM6oglLDBQjDBOKvIF5lWbVN4DfPd8UmUA0sSqIW 5lzXnExwUfsuE9LSGDkHOgyRsqs/eH4a9SA9B7hQ2p7Cwzsi6pcSbx+eoOXS2wwuSu66 +tF6kqKjux13Z/0TePl1bfp75EoFD555syK44oawM57aiWmyl6P7wG/znGFJU/ZAG7z/ ogRYPPDTq8VzvLYVJHkWNLOMDQ3Pjh0G2d4dsIpSxV7i4HVBaLYefmWRAm6wovb6LzPH OxLBVQVOkbk8ZfQTJTh4+LGvRHEcVk+fMr5P7wQVj7lWA6ITHJH80s2YzoOA9muyfIGR 9/DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774857094; x=1775461894; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yqoFzHrqxv2RFgrza41YChO6hXH6iktD/zgGiClPpPI=; b=apAlgBufmI0s02cUvbAXTOve9wDmjUC1HH5rSvLJaaA9TpG7eh0C19JLxUBynNtp1K 2jlpaC8e5AbU7BSIYNcggaINUQvB/S6GpLZU03OsoQILGyrddLUnrYh5c9ZfFM1Seb+5 aCFeeEQlZJlJunezMpXU7EFUiu1RZbmw83VNJHoMssmgCHrqhd/cdSPp7HQVRuUJDwA+ NwLbsffX7vWc7zQs1WdGGhEx8GiAMDAwEs1ZuTpMtJo6Z1LDFRdrv4C9y4OIa4DgUAXl TAQRKgrbI+5zEMkmYOxijwys++wQdpWhs/0Kryfjam8azcxb9B7o4QUTWpSGa3MESftk qLIg== X-Forwarded-Encrypted: i=1; AJvYcCXSXROHVhRHVFEmLY4Ui0XKzPrtBLnQ+0+t1e98tqJrmvrIiiCDkAQwL8VgwGzxcz+nxd6Jf/+aIsBWWTg=@vger.kernel.org X-Gm-Message-State: AOJu0YzQ2Z6NG6rCgC0yJB76GB0EmgOZ0lksrjBVlA9GOE6W4nRE+CW4 kDE4V5MmSW1NDbHfa0e1s6mRhEzJC/wMyWN8orsg5CcEX9ZiuVh6lj1lypp3Q2IT2v7HzzgUFlo QXQ/GQjorZPT7HIizRSiqsZuz+DGpdb21PbA0ec0DJ8lxB+CgiPjsBE2mZF7cTKu1iTs= X-Gm-Gg: ATEYQzzKPXpCYmNExrE+gaC/1oz8TR50i2GxSIXevwZB6q1xRCsbe6Z+y5d48j7nnJq b/YPftqnyc0fkjHzoEB6T6fD4Wnd+ehBGTCNhzGDDHuZ+FDdMDH2pd908RsXAke68ap8gkT1YRJ +SCewFRVdB0JeuvcRpRMhH4g0fgaXCzxLE0UWvD5r2LDTcKXJ8tVrfRnH4S4ydxXFtu6QmMHbdq iCx9ASUWkCxs+TKP9U3Ba0GuctOxzNcOXrcT0cDjEfjdd+pUrrTYYDqRm9+G93HWThTGbI2Tbo9 Wp0WFfQ7k97CpQMoGj7zYnfrVgD7ee9u7L7q324RMSNDUPr3FwrNFkAMKIhUpy6tmCNhJW877pi WfcpEFaAnZkzMm5sUWzeSxmDs9bttXidTzQdcwd2zGaqCHSs+xwU= X-Received: by 2002:ac8:7d8f:0:b0:509:1ee2:69e4 with SMTP id d75a77b69052e-50ba380a5e9mr165178571cf.11.1774857093969; Mon, 30 Mar 2026 00:51:33 -0700 (PDT) X-Received: by 2002:ac8:7d8f:0:b0:509:1ee2:69e4 with SMTP id d75a77b69052e-50ba380a5e9mr165178441cf.11.1774857093552; Mon, 30 Mar 2026 00:51:33 -0700 (PDT) Received: from brgl-qcom.home ([2a01:cb1d:dc:7e00:1143:869f:e06c:4587]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf247472csm14706938f8f.28.2026.03.30.00.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 00:51:32 -0700 (PDT) From: Bartosz Golaszewski To: Linus Walleij , Bartosz Golaszewski , Jon Hunter , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov Subject: Re: [PATCH] gpio: shared: shorten the critical section in gpiochip_setup_shared() Date: Mon, 30 Mar 2026 09:51:31 +0200 Message-ID: <177485708802.5892.11250894850372032857.b4-ty@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260325-gpio-shared-deadlock-v1-1-e4e7a5319e95@oss.qualcomm.com> References: <20260325-gpio-shared-deadlock-v1-1-e4e7a5319e95@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: cgkSZ2dXXTjx5oR8mNmX5-xkVb6ttqo5 X-Proofpoint-GUID: cgkSZ2dXXTjx5oR8mNmX5-xkVb6ttqo5 X-Authority-Analysis: v=2.4 cv=evLSD4pX c=1 sm=1 tr=0 ts=69ca2b86 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=rx2hHsDi30GigQfg1aAA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA2MCBTYWx0ZWRfX2p5DQa+d5ety I5NHtKWIGQScnF04XSSyaWPvePJEFbZm6cvilD1E5Zd188yiUgSKexYhvdE8stj6Ct4ELdPi0Zq 5P5PKOLddI3hoLVjrugsRDmSa8hTL22F6Sy9yF6rvL6BTgMDWWz/kbfBfggzLGF+6NVcsnmhoRR AxGTPf4haxorp6BpVe3P2HY9MHT10HJv1S0F1+vAzOnPDdHWRIuTVyYzckROUGvnwMmNCBjyuuF a2RotJfKiFM/HqgNjYcyuQBsvDAhfdh4DuVv4fMk+GpMfJiYtjlMwiMrTgF4R1slgw68zWctJl5 k1axNQ0naqQOJEakeT9v8bXrFqDZKMY8Mjx/EdepMrj2m/7PhfRw8/i4pimXnJpmNyi5lp2uGyV v1pDIVr2jXvnJSVOD/uVM4JYTUawGg4aCqpRrhhyMwsrgHoIMP8MNwIiOi+SIleJXfu54pKFFXQ QjEzDY0svwNf06M4+Ww== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300060 On Wed, 25 Mar 2026 12:06:38 +0100, Bartosz Golaszewski wrote: > Commit 710abda58055 ("gpio: shared: call gpio_chip::of_xlate() if set") > introduced a critical section around the adjustmenet of entry->offset. > However this may cause a deadlock if we create the auxiliary shared > proxy devices with this lock taken. We only need to protect > entry->offset while it's read/written so shorten the critical section > and release the lock before creating the proxy device as the field in > question is no longer accessed at this point. > > [...] Applied, thanks! [1/1] gpio: shared: shorten the critical section in gpiochip_setup_shared() https://git.kernel.org/brgl/c/310a4a9cbb17037668ea440f6a3964d00705b400 Best regards, -- Bartosz Golaszewski