From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9A013BD64F for ; Fri, 3 Apr 2026 15:14:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775229286; cv=none; b=T/L5OAVdiw4zg+hI6oUMAxphIe3dnAHkNoS00z0KqnFCHPHWzHH5eOQpq36yqg6dxspDrbjsAi3is9hDJE3lfPEYMyT6DHCWbDcHVJpcrhA/jLkZxh6tobJzq4Cdez9ZmtZpgvlgATHlSHNobrGtU3IzPot66VOJ1yJ6y9doIDc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775229286; c=relaxed/simple; bh=p+ASDUdYz84jNx3iUfg4BSpMmcpuNqwANUP22/J2WOo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=hPghA8CmuxJ04vpS3Sf8c2SKHkGRDiarFnmktjAZcWaiS0Z/lRJun8hHRiwH6/sw3u+5chPb7GxwWP4s3pAvxFKAPPumzV2eeLq/xlsCu37IrunsMruip/sc/DcW/kHAw4tHFY/Ux4iDwQjHZlydwliqWgiNqC8iqYHeSFb6Bw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=EFCkAc7B; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EFCkAc7B" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-82a6c70f1f8so1291106b3a.0 for ; Fri, 03 Apr 2026 08:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775229284; x=1775834084; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=vx3cX0Um4XbIxAKRYiUqFyiIniVc/uoy8TRTh+aipB0=; b=EFCkAc7B4e4++rbuv3e5zAL+8FsHE72/ReW7M48IJQnSrhMSsGVZC15n0AQYZoKr5S FussCS/aOje/s8GjzZ9bvIITQJ8wUuVxoP7biOhcbAGJI7oA0E6tg3anC8UXQZUfiH3i 8ZB0X4hJ/As6YvQdrIuhazEkv4erb4M4b+FVm5EwLZOrrhRk4o3o9YA5Iwq2lLFuq3Bq mAUXZ87MlXFU3hIVcc+2yzk9QtgNnqM0LPfvF5X5Kd517wWOSmHyXNfvTT+CTV+koChF cpJsLpM1YJ/NtMr7pQCd2kKbtRYeDqj5OAGlAfloRAIhvXaTrfyKgVRQohQDYeH6z/k0 uhaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775229284; x=1775834084; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vx3cX0Um4XbIxAKRYiUqFyiIniVc/uoy8TRTh+aipB0=; b=I3FZajvqsXB5droVaG80TgYRP5HLa1SXXnLSxPSS4tF/z97f02FJOHLcduTJLEnDmF CXFklEI3vJbbGsH3G+nIFDWwizYgqDo9tmCpA93hpc7D2QnzoYlugQnMXxFAglhJe4R9 Fdx1AkORusD9MbzioDLrSrneLB/01HcPDgESsDB7w5qMv8LXA0mUoSUedS3AkbOJ9n+C GAfVZLlddgWh69qqoyVdkZ+1gB0FJsUXrsj4YXu9K7y3EM3X4uXdh6y9/bdk5tIVsZyF l5DPhRdnwd8d3xrXD7kaPGp0FwC0xP9sGjGeTJW14mxdB0hytoEcHqi2Ukr60p9d11tO zyTQ== X-Forwarded-Encrypted: i=1; AJvYcCX4G4sjJkk2FZC9Xk+negW4HhXn1PAogpWvIZ3JgE8xTJc5BXr4wIsL09ugHTi6nGK3R0uEKP8Dw2OOMXs=@vger.kernel.org X-Gm-Message-State: AOJu0YzkODnzcMggjhEZFhFKoQrAT1TaMmBS67N7Hf8OshNEFIZOvYbu og0vQXYp7KNdhQtYgWgi/1PEVQ1WcDt5eMZOIR+eNYRINrf6Vq6xTWYjj5v9bKW6YeJmGAgWV1D +JEOFUg== X-Received: from pfiv17.prod.google.com ([2002:aa7:99d1:0:b0:82c:67aa:804]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:10c6:b0:81f:4a0c:c584 with SMTP id d2e1a72fcca58-82d0da44954mr3417884b3a.1.1775229284032; Fri, 03 Apr 2026 08:14:44 -0700 (PDT) Date: Fri, 3 Apr 2026 08:13:54 -0700 In-Reply-To: <20260123090304.32286-1-jiangshanlai@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260123090304.32286-1-jiangshanlai@gmail.com> X-Mailer: git-send-email 2.53.0.1213.gd9a14994de-goog Message-ID: <177522907944.296735.10194559706279197463.b4-ty@google.com> Subject: Re: [PATCH 1/2] KVM: x86/mmu: Don't check old SPTE permissions when trying to unsync From: Sean Christopherson To: Sean Christopherson , linux-kernel@vger.kernel.org, Lai Jiangshan Cc: Lai Jiangshan , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , kvm@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Fri, 23 Jan 2026 17:03:02 +0800, Lai Jiangshan wrote: > Commit ecc5589f19a5 ("KVM: MMU: optimize set_spte for page sync") added > a writable permission check on the old SPTE to avoid unnecessary calls > to mmu_try_to_unsync_pages() when syncing SPTEs. > > Later, commit e6722d9211b2 ("KVM: x86/mmu: Reduce the update to the spte > in FNAME(sync_spte)") indirectly achieves it by avoiding some SPTE > updates altogether, which makes the writable permission check in > make_spte() much less useful. > > [...] Applied patch 2 to kvm-x86 mmu, with my proposed tweaks. [1/2] KVM: x86/mmu: Don't check old SPTE permissions when trying to unsync SKIP, for now. [2/2] KVM: x86/mmu: KVM: x86/mmu: Skip unsync when large pages are allowed https://github.com/kvm-x86/linux/commit/b3ae3ceb5569 -- https://github.com/kvm-x86/linux/tree/next