From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754504AbbFWKOH (ORCPT ); Tue, 23 Jun 2015 06:14:07 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:59135 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754241AbbFWKOD (ORCPT ); Tue, 23 Jun 2015 06:14:03 -0400 From: Arnd Bergmann To: Gaston Gonzalez Cc: gregkh@linuxfoundation.org, paul.gortmaker@windriver.com, dilekuzulmez@gmail.com, gdonald@gmail.com, cristina.opriceana@gmail.com, hamohammed.sa@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192u: ieee80211_rx: Fix incorrect type in assignments Date: Tue, 23 Jun 2015 12:13:47 +0200 Message-ID: <1775494.ZyQRebyBWF@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1434924729-21086-1-git-send-email-gascoar@gmail.com> References: <1434924729-21086-1-git-send-email-gascoar@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:39l0SeWKj02a9Q+ORJr/q/bNj/M+p54tBlZrofrraRmUhGWuqMM SEVB+m6Y/TYpiBdlRze4WeKtRX7tNGU0+g1DcJkzuSFSXhbFxvS0GZ4S6F5N6JqxjlTZxvI G2bUkchJ9htNx+F0X0f908y7v9+UvXU5hV7R95JJ2RXORKbEFlFZtEboZIatCkX67JG9lyt QXxZt2oFu0zPLvvIOmQyA== X-UI-Out-Filterresults: notjunk:1;V01:K0:euLSDk00Fo4=:n2MtKy/jF+Kn9MgylJ+wq/ 9jg/5BqFjH69T4uPbGWWujdEF9987+2EH82Ta2NPmE3+d4Yyk4oUJ6Zs6aEL/rn6Y+Ffzul7G aozNyQDU+ZGk2fgkEnYcJsKyiUrxgcxvTWwF/QcYw6EVJ0JSXXRW9t+dH/+qJ9TF/yavZJzD8 idtDzdYtCNbyDJuUnZVnlTU7Rbi0FT/MYOnJxP38deFkrfxixsxW11J7qgEMg1pXk+nVAM1/W vufq64ukmbs/rkjNGW7MHRl+2sab/OQohLdWU3db7kZQ8zxnrEGmvHhEdsGIv5my8KGKGEyl0 V+8IhWBXU3UPdHrKf2VVW7T4r+L/ijyBwVXa4mXG8PIPeBdDhq/KhPLRjmzXXyFLVwKmm/3nw SQawzJbFVbp+qFO5Rty1Wx8x40V24aUzoVsXi9y2P6DwYfcDfVllbHvTwOnWHR4WqFUVnElRH IParFikQ8ftLQwjOA5Stos/whPVsMm0HibCFt7F7n4qFBkfsYouDXFE/baSFEesKeHIsdElTH YPiEdiZxejcS/vDnTnkNSnahyt3g/P4vWp44oxobcCH3wneZapCj8qDZ4RMA3Y7TCpIG6dP79 f+S3a+1KsQMotGEVIOC4ySswYt554DylgreTgZyH0uMlfne1OvxpUMwEuMqdhH9EgpwBCSVoV hWPbZ3z9+tdxuZ5+yuYMoUGXb7lflmSafbOSyrfrMwOPLKw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 21 June 2015 19:12:09 Gaston Gonzalez wrote: > /* WMM spec P.11: The minimum value for AIFSN shall be 2 */ > qos_param->aifs[aci] = (qos_param->aifs[aci] < 2) ? 2:qos_param->aifs[aci]; > > - qos_param->cw_min[aci] = ac_params->ecw_min_max & 0x0F; > + qos_param->cw_min[aci] = > + cpu_to_le16(ac_params->ecw_min_max & 0x0F); > > - qos_param->cw_max[aci] = (ac_params->ecw_min_max & 0xF0) >> 4; > + qos_param->cw_max[aci] = > + cpu_to_le16((ac_params->ecw_min_max & 0xF0) >> 4); > > qos_param->flag[aci] = > (ac_params->aci_aifsn & 0x10) ? 0x01 : 0x00; > - qos_param->tx_op_limit[aci] = le16_to_cpu(ac_params->tx_op_limit); > + qos_param->tx_op_limit[aci] = ac_params->tx_op_limit; > } > return 0; This certainly needs a more thorough description of how you determined that the byte swaps that you add are in fact required. Did you test it on a big-endian machine? Arnd