From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: W_Armin@gmx.de, hansg@kernel.org,
Ethan Tidmore <ethantidmore06@gmail.com>
Cc: wse@tuxedocomputers.com, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: uniwill-laptop: Fix signedness bug
Date: Thu, 09 Apr 2026 16:41:14 +0300 [thread overview]
Message-ID: <177574207482.8529.7240891931349170592.b4-ty@linux.intel.com> (raw)
In-Reply-To: <20260403070928.802196-1-ethantidmore06@gmail.com>
On Fri, 03 Apr 2026 02:09:28 -0500, Ethan Tidmore wrote:
> The function sysfs_match_string() can return negative error codes and
> the variable assigned to it is the enum 'option'. Which could be an
> unsigned int due to different compiler implementations.
>
> Assign signed variable 'ret' to sysfs_match_string(), check for error,
> then assign ret to option.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: uniwill-laptop: Fix signedness bug
commit: 6b0567dc4c9ad140044400e06dd97fdce12c204f
--
i.
prev parent reply other threads:[~2026-04-09 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 7:09 Ethan Tidmore
2026-04-09 13:41 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177574207482.8529.7240891931349170592.b4-ty@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=W_Armin@gmx.de \
--cc=ethantidmore06@gmail.com \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®