mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julian Braha <julianbraha@gmail.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: firmware: efi: fix Kconfig dependency on CRYPTO
Date: Sun, 28 Feb 2021 16:32:20 -0500	[thread overview]
Message-ID: <1775911.au21gMaO99@ubuntu-mate-laptop> (raw)
In-Reply-To: <CAMj1kXGYUwttj4QYSaM-aqtThenXc3hds6VmfOTsQHApVKhjgQ@mail.gmail.com>

On Sunday, February 28, 2021 9:30:29 AM EST you wrote:
> On Sat, 27 Feb 2021 at 04:29, Julian Braha <julianbraha@gmail.com> wrote:
> >
> > When EFI_EMBEDDED_FIRMWARE is enabled, and CRYPTO is not enabled,
> > Kbuild gives the following warning:
> >
> > WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
> >   Depends on [n]: CRYPTO [=n]
> >   Selected by [y]:
> >   - EFI_EMBEDDED_FIRMWARE [=y] && EFI [=y]
> >
> > This is because EFI_EMBEDDED_FIRMWARE selects CRYPTO_LIB_SHA256
> > without selecting or depending on CRYPTO, despite CRYPTO_LIB_SHA256
> > depending on CRYPTO.
> >
> > Signed-off-by: Julian Braha <julianbraha@gmail.com>
> 
> Could you try the below instead? CRYPTO_LIB_SHA256 should not depend
> on CRYPTO in the first place, we should fix that if we can
> 
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index a367fcfeb5d4..77e6bc6df0ee 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -1936,9 +1936,10 @@ config CRYPTO_STATS
>  config CRYPTO_HASH_INFO
>         bool
> 
> -source "lib/crypto/Kconfig"
>  source "drivers/crypto/Kconfig"
>  source "crypto/asymmetric_keys/Kconfig"
>  source "certs/Kconfig"
> 
>  endif  # if CRYPTO
> +
> +source "lib/crypto/Kconfig"
> 
> 
> > ---
> >  drivers/firmware/efi/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
> > index 2c3dac5ecb36..f914da9845ac 100644
> > --- a/drivers/firmware/efi/Kconfig
> > +++ b/drivers/firmware/efi/Kconfig
> > @@ -248,6 +248,7 @@ endmenu
> >  config EFI_EMBEDDED_FIRMWARE
> >         bool
> >         depends on EFI
> > +       select CRYPTO
> >         select CRYPTO_LIB_SHA256
> >
> >  config UEFI_CPER
> > --
> > 2.27.0
> >
> 

Hi Ard, this solution works fine, and doesn't seem to introduce 
any new issues with unmet dependencies.

- Julian Braha




      reply	other threads:[~2021-02-28 21:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-27  3:29 Julian Braha
2021-02-28 14:30 ` Ard Biesheuvel
2021-02-28 21:32   ` Julian Braha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1775911.au21gMaO99@ubuntu-mate-laptop \
    --to=julianbraha@gmail.com \
    --cc=ardb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®