From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Luis de Bethencourt <luis@debethencourt.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] cpufreq: integrator: Fix module autoload for OF platform driver
Date: Mon, 05 Oct 2015 22:51:42 +0200 [thread overview]
Message-ID: <1776253.J5g3a7BOh2@vostro.rjw.lan> (raw)
In-Reply-To: <20150917015756.GQ29943@linux>
On Thursday, September 17, 2015 07:27:56 AM Viresh Kumar wrote:
> On 16-09-15, 22:24, Luis de Bethencourt wrote:
> > This platform driver has a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> >
> > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> > ---
> >
> > Hello,
> >
> > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> > that information so modules have the correct aliases built-in and
> > autoloading works correctly.
> >
> > A longer explanation by Javier Canillas can be found here:
> > https://lkml.org/lkml/2015/7/30/519
> >
> > Thanks,
> > Luis
> >
> > drivers/cpufreq/integrator-cpufreq.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/cpufreq/integrator-cpufreq.c b/drivers/cpufreq/integrator-cpufreq.c
> > index 2faa421..79e3ff2 100644
> > --- a/drivers/cpufreq/integrator-cpufreq.c
> > +++ b/drivers/cpufreq/integrator-cpufreq.c
> > @@ -221,6 +221,8 @@ static const struct of_device_id integrator_cpufreq_match[] = {
> > { },
> > };
> >
> > +MODULE_DEVICE_TABLE(of, integrator_cpufreq_match);
> > +
> > static struct platform_driver integrator_cpufreq_driver = {
> > .driver = {
> > .name = "integrator-cpufreq",
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Applied, thanks!
Rafael
prev parent reply other threads:[~2015-10-05 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 20:24 Luis de Bethencourt
2015-09-17 1:57 ` Viresh Kumar
2015-10-05 20:51 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1776253.J5g3a7BOh2@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luis@debethencourt.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®