From: EunTaik Lee <eun.taik.lee@samsung.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: EunTaik Lee <eun.taik.lee@samsung.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"vladimir.murzin@arm.com" <vladimir.murzin@arm.com>,
"suzuki.poulose@arm.com" <suzuki.poulose@arm.com>,
"riandrews@android.com" <riandrews@android.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"salyzyn@android.com" <salyzyn@android.com>,
"Dave.Martin@arm.com" <Dave.Martin@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH RESEND] arm64: add alignment fault hanling
Date: Mon, 15 Feb 2016 11:48:57 +0000 (GMT) [thread overview]
Message-ID: <1776444859.925581455536932926.JavaMail.weblogic@epmlwas09b> (raw)
> How do you end up with Device nGnRnE in user space? I thought we should
> have got some guard page.
I guess it is a device file that is mmaped in the user space and later remapped in the kernel
using pgprot_noncached().
I can't find the code that inserts a guard page in between vma's can you please help me find that code?
> do_strncpy_from_user() relies on unsafe_get_user() not being able to
> read 8 bytes. The problem now is that it doesn't get a page fault but an
> alignment one is isn't handled.
Yes.
> Why addr >= TASK_SIZE? addr here should be the fault address, not pc.
You're right. I should have used user_mode(regs).
> The simplest would be to use do_bad_area() here without any additional
> function.
Yes, I should've probably used do_bad_area(). I just wanted to do the minimal stuff.
next reply other threads:[~2016-02-15 11:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 11:48 EunTaik Lee [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-02-15 11:44 EunTaik Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1776444859.925581455536932926.JavaMail.weblogic@epmlwas09b \
--to=eun.taik.lee@samsung.com \
--cc=Dave.Martin@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
--cc=salyzyn@android.com \
--cc=suzuki.poulose@arm.com \
--cc=vladimir.murzin@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®