From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F050330666 for ; Fri, 17 Apr 2026 20:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776458369; cv=none; b=r3oDUB4QSyhHZDK/2mVemHV044d8xi6jjEUAAs0frplZI3FCQ96Q9lBN0H/iPpL4ZZausGdkG36hV7ctXEpKHs/Hp/hnVemu+Qevo0sEtWVTyZbU6/47klISYtBARfgsio1uLKkxVTs9+2SDcsGrwuuJJeP6dZQV1LopPIq6FH0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776458369; c=relaxed/simple; bh=QYmKPZ5u/6MDW8voyINPo8MxBXRPsCZP02IXVl+yo60=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=BYUZFOvrFvU+MCLMxswD3IAgE+RImGxUVhelvEKIDCFp713p9t+QbKZvNdptn0e1i4M19d3jeqDbDrWjoXWwxekGKFIEXvBwt0WE4eRMUy0FYGj1dwqMyImPZ6MWp4t3itgSwnvKCtjL4bipG0LCX/mmS8AZCQYpN17+fR9nr78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=eK3U4RI6; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="eK3U4RI6" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-4645dde00a7so1768750b6e.1 for ; Fri, 17 Apr 2026 13:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1776458367; x=1777063167; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H8T8fhnGDggKVoWa5C5JOmcQbWxbtuCBK3biN6O1EZQ=; b=eK3U4RI6hD8c14vJUmIIMgalhfxuQs8eJiZ7JP64Jv1RJIipF8bmJ/orcVZfYr44IB ERRrp47rfGklvIv7bzuJaX9a1jWExK/INAxOWGCoW5oN7dErjtdRrm/+WV7sXC8QplbA gKkt69ZoB6t1Djtq0CkfV8j04lskguJ7skvoAdhO9pmiqnXETtGeT/CbozJG1H8KhLvm qF1GKSxUPp96owlDQ1/zqluf9QJQ9TCD4EToAp4YSIsbVXjACTPKOxJ6EipZYBpwy7rv PQIqcqp3RJxMmW/CoNMMxXQaGRniYTGTfVGnsklupPHad8/STXoUbPzIUuz0b9dS7th0 hL1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776458367; x=1777063167; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=H8T8fhnGDggKVoWa5C5JOmcQbWxbtuCBK3biN6O1EZQ=; b=kYZJxaxWpB8svw7sPkvnLDZCERSUmvx0qzqbemc2/zb6gG5Ng7o86wwGHk3XcPlEbN UdNehZMn4tUkxKZYVa/IWrgzOeaK8uiwdOlA/EB7+xj5swmy0Y6l8X4dDmH1HI1XSqLC VyA+/a1M3pjTRbO9z8wgAf4SdvdQ/gC3S1Fyu5D7NK5mCprXeXLjA3yPp9lqk9+xGlhy 2w3Ww+QBn+459AFz9nSXy8eHz5M65p9/3NBivE4wI7JoG8LQFIAtsuyoOixs6vlRl9bW I2jQWViIjzsudaKyJRSiuWq+XYE4iWKE5n77UxDPXqXPlGllyeB8mHxgr3igtBRhkz5G ak1w== X-Forwarded-Encrypted: i=1; AFNElJ/ydHZL9IYKqQw7iFaE+OOJHGDY9/9Us+Ixj7YO4IuNnw6wWV+3235/9/BR5MYNBgjWa+KNkTrljKPA/uw=@vger.kernel.org X-Gm-Message-State: AOJu0YyEsmDUfMtOQoTytTERGiKA3qsO3OEat/4FqfbGHESCLvaoa8BV 6vdTXhWPGWNLcpXHMe0QQHiDfylEfCZqZzaJnJzVset2tJbv/253cuLgODZDwMgEciVshavx2wu STAx560o= X-Gm-Gg: AeBDievDv87+I5c49W1m4ZH6My1/oP0wP/iX0lRD2jgvIrFaPI7QbtoDR/IvDsNGuz9 E1yJWj21jiOFzqDdbOHC+eXqEWSLGc7xkT7ztAPb7rt8s6j9qh+Pr/qbSK2d9+oa9aQ8pD/puWs 23i4if+T3nMpW0W1in2Wrq2tjggN88PRSXygWRFBPTr9Ru3XncRDbiJaNVSmutzYLCc+FsLjAMc Hwnn4kzEvmMyan6fd8CCZCkRU1xJL+bWsdwqqbrdFnlvhsbiwZhItVPeAW4l720P0a00SfF2iyK n7QOTTKLB57kExuelMcyMHrQrBmLF6byZHRqGnpG97RHDWZ+sJiUXTi3ECxiyCJ6kBcQIkdU5m9 6wE4ynRnWxRBcEDk/TmRTL3wRt7rkzBPCxtY+97mPMbJ+sdEgulTb80DvzLr+xszIr+HfrsMisy SY/HYTPGOrJjjA5yhExOXFo8Jgfu02r4f/S6YUWNOA7UGj10pQHKqh2ZJ29eE/3QEJDbqw67urz LdSwtj5uGNfAqo= X-Received: by 2002:a05:6808:50a2:b0:471:6b89:b72c with SMTP id 5614622812f47-4799bd624b6mr2093291b6e.13.1776458367186; Fri, 17 Apr 2026 13:39:27 -0700 (PDT) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7dc9759bfa3sm1926469a34.13.2026.04.17.13.39.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 13:39:26 -0700 (PDT) From: Jens Axboe To: Denis Efremov , Greg Kroah-Hartman , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Guangshuo Li Cc: stable@vger.kernel.org In-Reply-To: <20260415145708.3331818-1-lgs201920130244@gmail.com> References: <20260415145708.3331818-1-lgs201920130244@gmail.com> Subject: Re: [PATCH v2] floppy: fix reference leak on platform_device_register() failure Message-Id: <177645836617.906013.5675762942401997007.b4-ty@b4> Date: Fri, 17 Apr 2026 14:39:26 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.15.2 On Wed, 15 Apr 2026 22:57:08 +0800, Guangshuo Li wrote: > When platform_device_register() fails in do_floppy_init(), the embedded > struct device in floppy_device[drive] has already been initialized by > device_initialize(), but the failure path jumps to out_remove_drives > without dropping the device reference for the current drive. > > Previously registered floppy devices are cleaned up in out_remove_drives, > but the device for the drive that fails registration is not, leading to > a reference leak. > > [...] Applied, thanks! [1/1] floppy: fix reference leak on platform_device_register() failure commit: e784f2ea0b4fd0e7b70028ff8218f22456c5dcf8 Best regards, -- Jens Axboe