From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Dave Hansen <haveblue@us.ibm.com>, Andrew Morton <akpm@osdl.org>
Cc: Patricia Gaughen <gone@us.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix Summit srat.h includes
Date: Sun, 07 Sep 2003 21:06:14 -0700 [thread overview]
Message-ID: <177650000.1062993966@[10.10.2.4]> (raw)
In-Reply-To: <1062959739.27214.2174.camel@nighthawk>
> I was compiling for my plain 'ol PC, and was getting unresolved symbols
> for get_memcfg_from_srat() and get_zholes_size(). The CONFIG_NUMA
> definition right now allows it to be turned on for plain old X86_PC.
> Does anyone know why this is?
Yeah, distros want it, so they can ship one kernel for SMP that covers
NUMA and non-NUMA, switching dynamically.
> depends on SMP && HIGHMEM64G &&
> (X86_PC || X86_NUMAQ || X86_GENERICARCH ||
> (X86_SUMMIT && ACPI && !ACPI_HT_ONLY))
>
> In any case, the summit code incorrectly assumes in at least 2 places
> that NUMA && !NUMAQ means summit. Someone was evidently trying to cover
> the generic subarch case, but that's already taken care of by the lovely
> config system and CONFIG_ACPI_SRAT. This patch fixes those assumptions
> and adds a nice little warning for people that try to #include srat.h
> without having srat support turned on.
Nice, thanks. Yeah, the generic NUMA on generic PC code will need a bit
of tidy up, but it should more or less work ;-)
Thanks,
M.
prev parent reply other threads:[~2003-09-08 4:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-07 18:35 Dave Hansen
2003-09-08 4:06 ` Martin J. Bligh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='177650000.1062993966@[10.10.2.4]' \
--to=mbligh@aracnet.com \
--cc=akpm@osdl.org \
--cc=gone@us.ibm.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®