From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: mpearson-lenovo@squebb.ca, derekjohn.clark@gmail.com, i@rong.moe,
Yufei CHENG <cd345al@gmail.com>
Cc: hansg@kernel.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] platform/x86: lenovo: wmi-other: Fix uninitialized variable in lwmi_om_hwmon_write()
Date: Thu, 30 Apr 2026 16:54:23 +0300 [thread overview]
Message-ID: <177755726340.2048.13579078421388409410.b4-ty@linux.intel.com> (raw)
In-Reply-To: <20260426165034.9073-1-cd345al@gmail.com>
On Mon, 27 Apr 2026 00:50:34 +0800, Yufei CHENG wrote:
> When the flag relax_fan_constraint is set, local variable 'raw'
> is never assigned, and lwmi_om_hwmon_write() will pass uninitialized
> value to lwmi_om_fan_get_set() resulting in undefined behavior.
>
> This flag allows user to bypass minimum fan RPM divisor rounding,
> but assignment to 'raw' only happens in the non-relaxed path.
> Fix by defaulting 'raw' to user provided 'val' in the else branch.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: lenovo: wmi-other: Fix uninitialized variable in lwmi_om_hwmon_write()
commit: 863810d4985ad214f70c1623f24384ccc850f2a2
--
i.
prev parent reply other threads:[~2026-04-30 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 14:59 [PATCH v2] " Yufei CHENG
2026-04-26 16:07 ` Rong Zhang
2026-04-26 17:43 ` [PATCH v2] platform/x86: lenovo: wmi-other: Fix uninitialized Yufei CHENG
2026-04-26 18:22 ` Derek J. Clark
2026-04-26 18:38 ` no name
2026-04-26 18:47 ` Derek J. Clark
2026-04-27 1:14 ` no name
2026-04-26 16:50 ` [PATCH v3] platform/x86: lenovo: wmi-other: Fix uninitialized variable in lwmi_om_hwmon_write() Yufei CHENG
2026-04-30 13:54 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177755726340.2048.13579078421388409410.b4-ty@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=cd345al@gmail.com \
--cc=derekjohn.clark@gmail.com \
--cc=hansg@kernel.org \
--cc=i@rong.moe \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®