From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E44E248F6F for ; Sat, 9 May 2026 15:31:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778340700; cv=none; b=o2hRYZ+/1jkLWJ3amuIuc5aq3083eKZwEJ8ssI2tUExNdOC+A6osc+dozW3YCww43dmDLO8hWAXVSjJysVAAlUMSRrPewvUiSnbuy1kGRrOS7BfHJ3ZmUM3MZNaPOoT8wAht2S5Et8qMZu+SpcdwzGRjIHa4+Bf+N8FPsmGd0Ns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778340700; c=relaxed/simple; bh=HCySDTlk/5AUy2ZQY8Bwy+NCIU64YMqRRrySRnB4Csg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=SLZXfnAMW0YW93TMrdgqQ/cc/mzCHDfqAyGiqM6yLMp757tBMWEq10Iy6HoPFLRoaYoSqg3LW5Fh+ecLJzYYlHwkfMi19HhZI4SlYkNou+6d6GpIZ8C+bHsHDxQP4SrcfHgbHzPwdcFxLDeCt9IhM0WWPKXmlZoKnvMBZCDdta8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dHG0gmvv; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dHG0gmvv" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-ba6838e76f2so382549566b.2 for ; Sat, 09 May 2026 08:31:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778340697; x=1778945497; darn=vger.kernel.org; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HCySDTlk/5AUy2ZQY8Bwy+NCIU64YMqRRrySRnB4Csg=; b=dHG0gmvv4aAOBLBusKjNeX0tYarzWTh74xwqusaTRoQHPG0CJ6kTRfILUpaDZ0oyxq lpRhZH1mCZVi6dlYixU+oUvXnGWFgBlDoxeY8wxnZ3xkqXn61uQgP3VcL+3OC7oqooj+ UDSK37ep2hc3zXYBMhDzWe3dL3580PvnDz46wBTPiP9hOYe/YJo33rXgNk0vEK+68s5Z 1G/PFTQmlgKwuEKs1reRdy0uVDsd+ly7rAxC0yDK+x1Y/d4vfpbcpjD43roIXoGOu7MD zR9Xn8oo+szcHJSfqXF/1uE1CtxxwnCoIzRmLblX9ZP8pezyWdgEBVdUPwKZ3xcCxips 7nnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778340697; x=1778945497; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HCySDTlk/5AUy2ZQY8Bwy+NCIU64YMqRRrySRnB4Csg=; b=bdO+SCksJ9PO7ZHyMnmE7O0widZwJAAQjpMMVr1T/97PTaQbSDwfJdMTe+MCRvsRid 1yZ5TrYC1/vO68zCzQ8S9xFbZUjX+7XA+TDd+eZX0zirlhPC7QUuR22zJtkWb6UFIPGv VXZ2t3GuAphfaZD+/Xx8arhm6e+6Cuz4tZYMmafzZ/bpzZ7qGKvn2PdRykFDDYChHstO GZTCNslhtknYRJuSRrbtXR01A/DljAiywzf9j9LP7UktWXLsS4msXePMJMXFuVrjktjQ zZz8aX3UAkCeylDrsxoXqnuVuqu0lIapVrCAsWlcaW4I5GkcYnToLtwJhnWrEVSIJrCY b5Gg== X-Forwarded-Encrypted: i=1; AFNElJ+4IesagxZcDTcsW3/8nZAA8sSPdIiJmxnWl13mxv+zMGsLpNXsPxPqD8iPq0k5Rynv2F3h3ra0fa6P37M=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7NndGonNdyI8S9AmbHq2Xr6WMWe1CVj7wPKDx0iCLjO+Ww05K SW82beH3aME9OUxwSHfKLesaEHF45hdBMTvaBNmTxLVd0vVMWEwaSDI= X-Gm-Gg: Acq92OEV8jTB6Hue2JW0RwqxoydyD91dc7qiE0L0LqPM4xs0PAhA0Ljbi2POlx1KL/P K5/TV40dNkYn7/MUjlUdnsGsYe5EB89NAaWwvLlDcky4yNZkLJhMuHmcH7sXlzKDppSwc4hJFoz 3iyIcQYYFWPSeWmDU/Yd+Uhkd6Kxt6N9chviGK40rumQWVuXEWgun6Yjwk9zST2XmMNxGMl9Uqw +0iORU5FJ2oIOYhPpCXfzgmxYlVIXbG7s/IRtSvC4Q3OYYGQKheGrbqINcYH/+gsVQeD4ozr7pV dA6/CZZ46Y1aVYCuXp/yAc3dTAEkiOGNH59ORZWxRFLlOoEq6Z5ZKBpYAwUcX6nbDLWrq0Bc00o lqKOnKhj9yiARYiQ4+Tqhf7kOXOv3KWV+Uko2AsMkp9V4PlQE3Wpz/d0xH/BBRh3qEBftU3jBvg bO X-Received: by 2002:a17:907:e148:10b0:bc6:14b3:e838 with SMTP id a640c23a62f3a-bc614b3f201mr807691366b.6.1778340696400; Sat, 09 May 2026 08:31:36 -0700 (PDT) Received: from debian ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4549120eab7sm12303834f8f.23.2026.05.09.08.31.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 08:31:35 -0700 (PDT) From: Tristan Madani To: Mikhail Gavrilov Cc: Marcel Holtmann , Luiz Augusto von Dentz , Johan Hedberg , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] Bluetooth: btmtk: handle FUNC_CTRL events without status field Date: Sat, 09 May 2026 15:31:34 -0000 Message-ID: <177834069495.1159760.2273651965423157568@gmail.com> In-Reply-To: <20260508173121.27526-1-mikhail.v.gavrilov@gmail.com> References: <20260508173121.27526-1-mikhail.v.gavrilov@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-05-08 at 22:31 +0500, Mikhail Gavrilov wrote: > Preserve that effective behaviour explicitly: when the status field > is absent, set status to BTMTK_WMT_ON_UNDONE instead of failing. > The OOB read remains closed, since skb_pull_data() still validates > the length before any further access. Makes sense. The hard -EINVAL was too strict for controllers that legitimately omit the status field -- falling back to UNDONE preserves the pre-fix behavior without reopening the OOB read. Reviewed-by: Tristan Madani