From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08B8548BD40 for ; Tue, 19 May 2026 14:27:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779200844; cv=none; b=AblV6nAcnGa3AU2Gs7IIITW8IokeYIZFXdsq+SXewo1j7Sz+aU5LrjxVuBzvvCf1X1nBIw0QNLYQe/UgrIwFw/AH8YzOge6xv2b0ClCTowdlu0nftZ0SHc8w/YCKjIhIWjPTp2MxNfIr2a+Q7eOTnG1UoCmY1ePBh6MORiqH+TI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779200844; c=relaxed/simple; bh=J1fIsSHzHA0cszZYZdv5tqXM8txWfOWm6rrYcIkswk4=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=GloIdtMMYE2A8+sPlZ0q9pVGY7CrfwSdhQGIijpyegqBsFmWT/B5Qladc7opP9C/yeI5/dmy6gChM51nVfxgB3+KHCK30X13f3MoLFbWVWnWNfuwNMy29XN0y/chMbLj3QvAccCseeBT+8q2CJgZW+cn9Oyetywa1byQsjnDMYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=c1Xj7Qj+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fL8BltYS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="c1Xj7Qj+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fL8BltYS" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64J9v4QZ1054774 for ; Tue, 19 May 2026 14:27:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zEjqKkH3DhRxJE8KbXYEAt37DhNV09bfllpxwdO6tRQ=; b=c1Xj7Qj+y951pKcH uJ+Yl/3DY/8BXEx+ZlTKrXTGbbvrzmwMIyoBGeH3lFeMseGuIZS0/wiGe+r6J/X6 ilx6hDAzNUbj7AjoUK9VnoQ6PX6yhMU3S1RzzEfs2Y0AXYRiRA8T4bC9eG/UgVxw /VfBzwmDKSM6DdE1WQtv2a1+mUYBouFwKHWY2n+2NHp/PDYjD6nRzGctUjCQf9Ip I/erEXcBAXT5nI64Zio4hTX0y3pyxfcfswOrUMl2FczqNb4yle30+FbL47UfcePA YjwqMYYVUdk4vV3H2W3unntEOlO8KaN1y7NpyJoaacoEcNTw3b8YLdjZLQ2YXhqn RD5gYg== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8npas243-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 19 May 2026 14:27:22 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82fa5ecd760so2044555b3a.0 for ; Tue, 19 May 2026 07:27:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779200841; x=1779805641; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zEjqKkH3DhRxJE8KbXYEAt37DhNV09bfllpxwdO6tRQ=; b=fL8BltYSasUtctsJmpu76QICz+0UmEy4fgZ5DeA+waavv79vNSnXxfogWCZqpnUgwx opnAVbF2m/NEVUmQq7WlOBBIEVSOQW6FXQLyVjYS4W4qhkubX2Y7BBQ3CegWXEWj4ke5 jQLGL9vKZbhppsyQatzc1OUM852X16vAG+ULtk2UHDdno1ELeTPRbGdq/8r89DUfnA25 geZUiW3A89yvaSzo4UxlWyw62FYrksjKtHoXqB8c726WfYHioP6yTjfcA6e9IgG42qlH O6k1WUBKDTzwOXUs/zVY/zq/GIyS7UP772iXeyFlviMp4Odk7Ya44QxtO+TNhUnwpXw2 E6CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779200841; x=1779805641; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zEjqKkH3DhRxJE8KbXYEAt37DhNV09bfllpxwdO6tRQ=; b=XlDUVdoDhiTaRNvtz82h7IAZU0xQFsOwVprRkh5VmTcJJ6w8J/NUtjrzjXU/awSrxG o4UZ9UcNDtgaMBEV7UYtqvoTp0JuKXpXeY8ug7BFhukd5fosjtCb8reKSbmKFH4m8MiS eCA/zSOTsLoYnV7IzZ5MxVwPr3fuV4hY2yNrB99aCX2yanI19NqZzLmVh7hSYCoYs2gG nXzai/B5y/y6h4NGK7thOvazul0cDqkQVG7rXeij/kuuTcgM5Ks7oR55epT9gjGxdoQW GT2J99E4vIWbPYtdalq0y8JE2efQ5EeS4sYXd1MwVhZJkKEpyDKmpguJ/EpZ5+CEsoaE tCDg== X-Forwarded-Encrypted: i=1; AFNElJ9mckW0QNvN8wegj/i11lZZqrKf3OQc7ZfaOnyucXVmB/ByI3+WJUXoyeAAVsCGt/yBsgXtz6y956P1ibc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5lF5yJDEX4ratX88oc4INHNFYImapUS0xiapEdyNSvOlmq78K SSeeNMitE99yl2eYx3CJVmJjngoJRadcMgvx3e1rSk4JKSYMVNJEhUgua2zzcoN/f16RnXR8TW5 tKj7T4w6qBRhufrg30yWeqranuMGOfgdZRV7rvvwp1XThOhGu/1T/8VfKj6HDHGqigoM= X-Gm-Gg: Acq92OHN9JwjrV/qRHYL+wXsD4jQ4sa7YLqxXi0VaPyac1vP+s1ypSMQA1PHssgdHez 6AkzWJT5gQqPOkdM1MgzjHLEua007R5Fb/HDAr67jO7yOlquNARy9ON2pqeI73kKINBuMYx+6Ma JmEGperJe8zgAh08ujdrgtqSs2kD7dz9DDuphqGjj1t13X5u6eK4zMAe8ESenKCbXkafSm/sDgj JQZ/XVNx1mTZUl2iCAdz/49npD6KSpPVeQaQO04dSyTr70EWlHGjKT3THPQFJlwGnF4GsFm0kS8 5mg/B3tr0+PjJa+jkOQ2bc4yruNoX4OAsstiSfkYC6bolJ59Ouh/X/qtaTQ6ElK3klyU3m332F9 3IkQ5WAcypezssyLgp9Gb X-Received: by 2002:a05:6a00:2e89:b0:837:80a:5ac7 with SMTP id d2e1a72fcca58-83f33f0fde7mr20707744b3a.45.1779200840893; Tue, 19 May 2026 07:27:20 -0700 (PDT) X-Received: by 2002:a05:6a00:2e89:b0:837:80a:5ac7 with SMTP id d2e1a72fcca58-83f33f0fde7mr20707691b3a.45.1779200840172; Tue, 19 May 2026 07:27:20 -0700 (PDT) Received: from [192.168.1.11] ([120.56.207.212]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f67eff284sm7640033b3a.8.2026.05.19.07.27.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 07:27:19 -0700 (PDT) From: Manivannan Sadhasivam X-Google-Original-From: Manivannan Sadhasivam To: Matthias Brugger , AngeloGioacchino Del Regno , Ryder Lee , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai Cc: devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Dan Carpenter In-Reply-To: <20260512103347.1751080-1-wenst@chromium.org> References: <20260512103347.1751080-1-wenst@chromium.org> Subject: Re: [PATCH] PCI: mediatek-gen3: fix incorrectly skipped pwrctrl error message Message-Id: <177920083522.97175.591150691760691771.b4-ty@kernel.org> Date: Tue, 19 May 2026 19:57:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE5MDE0MyBTYWx0ZWRfX3V9yQngiJYjj vl/LZU45wt4rJ/jt9a9LrdwCNL0nLFbwnoz4oS7mnrxS4aXoADj+rmTfoIrYxmVN4Z5r52w2f9a 5qU9OqJzDWBP40sqfyuuDkoyDToQ1O8x/xuw7FrvC3SLB8/Lzo20GC6hJzyqTRmj+vjmoGBmaCQ T00mYllmBJx/dyGlSFBzUjgFCX2i8vubmkMyWSNV6oxmkVe1B+qgQmApqTEPAbp2VpxEFnRGcD8 YT5xGjEZqa0wd6tMZcKjNlL1O3izU0Yabx3GSLDb7Uh0qeWbywDtVHjOP9Eef2jYb7BiD8xYdSH 7VF4fC59DcV6/c00sjRkJSqKu0a/ZzaMUY+BLVn3WyKKz6l4J8qeyb4ymZB8C+5zua76aZJHp+X BLLBTFs6zSeQn6y7Te70HrQBffmb+vQy67YIAVDHBldOXgsuRx4AC9WV3hzr80BsK+INSnAeE2O AkAIOiQ3ZADyZcSIL0w== X-Authority-Analysis: v=2.4 cv=NrjhtcdJ c=1 sm=1 tr=0 ts=6a0c734a cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=1gRTTRxgmbTSdBvl+srOOw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=bpYmCipijB_Evp6s3csA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: XEEN3rIfGrksvB7U9ysvt0BNQaT4NVRZ X-Proofpoint-ORIG-GUID: XEEN3rIfGrksvB7U9ysvt0BNQaT4NVRZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-19_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 phishscore=0 clxscore=1015 impostorscore=0 adultscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605190143 On Tue, 12 May 2026 18:33:45 +0800, Chen-Yu Tsai wrote: > When pwrctrl integration was added, the error message for when > pci_pwrctrl_create_devices() fails was incorrectly put after the error > goto statement, causing it to be skipped. > > Move the goto statement after the dev_err_probe() call so that the > error message actually gets printed (or saved if probe is deferred). > > [...] Applied, thanks! [1/1] PCI: mediatek-gen3: fix incorrectly skipped pwrctrl error message commit: 8ba433753d9b131c2e43b1ff7ba8c5730cef8231 Best regards, -- Manivannan Sadhasivam