From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12F0C1E0DCB for ; Sun, 28 Dec 2025 23:01:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766962902; cv=none; b=s90NaizeCDMzwPXrPn/tHkTwHs/Zcw4LBbc2iqevWapjxywBkZbpk9mB8VidRmiM0hDKP4qrGFeb24oM98TMH4RamXpVy72h99e+NuCABuHo9xfBc5mGnF/g2KYy/6drdF7x4YnvLPckWg6a/IJd/aE/ti/Vew2Su+fmSr8Lako= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766962902; c=relaxed/simple; bh=lHvs+AS60ERjcq1X1budWxiN3feMaLF9QU5ObXZ4Xi8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rJjLChacC7Aw8sBngnAYHTtmesHkNqxQBi1H9Uvh245qfpYBd9SUobln1xrTOghz9uq0+eZb7Nd8qd+Rpe3nOAL1dU+IfdWrm0LH359yIa8rsteO7HrBFD87+QVBllaoXO+SK/Zr66XYk4nqj4hjip7W+9vYWWDFG5opVfJVtyg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dp10o+Tz; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dp10o+Tz" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-4327790c4e9so1203076f8f.2 for ; Sun, 28 Dec 2025 15:01:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766962899; x=1767567699; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BQwvTTfub3W1PDZlXN4H91fhjPLj3fy6KDrLi83N24M=; b=dp10o+Tz+22YiMzAV3xNhVsVir3Fy8tovkEjoeafvOcpWNKR+9VHgI5iHiAA8eW94H e0pcL9ZnvOkEUqy9I/WbCjTYzBZE8rl+6tIfHd+yv1GiVlSNV4oYcEIBllFStkc9pvag 3m1yeuVUthrrbG6jKyrnU8vs7JnnpN613LgQ2KWoaPUCdhURpiIPlhH+z90j9aDu6ogB RC2OfLy8wfcCFFnZT6EOQJ3BfPQv+3FgyiNKkr1GI9pH5693rFX+AYgRx6PT/Lq6URkv q558PoiX0guQOmQNhxUoIQceeHeY6jPFgSfWiIBpeTydVBedddTbp/sC7BgaD3Q/FgrK 6wMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766962899; x=1767567699; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BQwvTTfub3W1PDZlXN4H91fhjPLj3fy6KDrLi83N24M=; b=Xs2INJQF/mfrxq1oreOTIusHGGbUxtrneGXwOwqCjQi/uPv0bP2wJnZ4a3fRdy67cB SK+VWcCEHTqzf+YcgFQfOvuwUlkRHaI3sf1DGv+iQrsOwLCslMeptUPK0Zs6+iT/IvEf nzQBI7NEbATKPKU6FDPK2MbNK1dEnL+26hFiju7ajfbdGAgKG6Oxtr/mySgJlG7N2vcb ww31dEIO013qxcBa2Se1DxGYc8hLt3nJ+jZ7DfYjUexDqoo4E77HNJrDag7lmWkpDmVn UgM8dmchqkmEAs+z6gTDEPGaXFMMT7BMZihfvYz/0RzBI4UN7om03EeLfX6V/Fv+Hcr9 +Z6w== X-Forwarded-Encrypted: i=1; AJvYcCUFU5d4q3aXmDVNjT17maqMdCOowMg8f5actBfhgjeOLQC0SX5O4puKkzG4kTd/2+w1sYeIfp7JncfLEjQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwRB7O3nD0aGn/a3qKAu5aLtOFaT8NKh7Mq1l7VYjs3Wm0mRYka xTzOh53slUEmT2NIuy617CKH3zqHj8c/bbgQgT2Os5NHS7OAp+t2qwke X-Gm-Gg: AY/fxX49nuVHs1ccyuaWcNTvt2uXdQRBUjIDNi8mdtq2P8NJa1/kxVHIuilorfll8aC igca9/VISlfaY5qAVkA/K47IVwZ/r42fwO1NB+MnfeUjCZm8o1dZWmX7EsOL+ULh9hK4lfqd8At WMHaK6GZebsL2bOHWxkH+Ba7IG2lv74qnvGMDpyO9K7a9fJvzmGBRWteOtiZxJrn4+jaE6Iplt8 H55s3vVSzdjI2rWS9Zp4lc6jeW9hsU66OjjCzmuCscfO+VbW0vMdG7Vs4+utaHs/NqWKzRz6aSl 8r/En3aw9kGetBq8Tg8YWUqkB6OprQWC+Bjua81UvsIvoZPVdBh1mxS7cFAvKb2p/thlw1r0dKx yMX1UB6ie23IvvpxyiIbC2+Cj5s3UaWViuT8+kJq6Coq7atQhIgox884hRbgi6KwTatIv03A9oy xKsi7DDe0+qBwWzZVy1TSEfd3V X-Google-Smtp-Source: AGHT+IEle3tOX40aI8Z+pBUJfzESTXjJiSMp4thV8HBHvnHegXUiGsTfpQ2oYRXR0/pBEDgqKU3BXA== X-Received: by 2002:a05:6000:2882:b0:431:488:b9b4 with SMTP id ffacd0b85a97d-4324e4c8fa8mr30131416f8f.17.1766962899166; Sun, 28 Dec 2025 15:01:39 -0800 (PST) Received: from [192.168.100.5] ([156.197.225.47]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1afbfsm59550694f8f.9.2025.12.28.15.01.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Dec 2025 15:01:37 -0800 (PST) Message-ID: <177927f9-e4f8-4f5a-bc71-f42f01c34b2e@gmail.com> Date: Mon, 29 Dec 2025 01:01:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm: pl111: fix build regression To: Arnd Bergmann , Linus Walleij , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Arnd Bergmann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20251223214915.503913-1-arnd@kernel.org> Content-Language: en-US From: Eslam Khafagy In-Reply-To: <20251223214915.503913-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/23/25 23:49, Arnd Bergmann wrote: > From: Arnd Bergmann > > The drm_info() function requires the drm/drm_print.h header to be included > first: > > In file included from drivers/gpu/drm/pl111/pl111_nomadik.c:7: > drivers/gpu/drm/pl111/pl111_nomadik.h:11:32: error: 'struct drm_device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > 11 | void pl111_nomadik_init(struct drm_device *dev); > | ^~~~~~~~~~ > drivers/gpu/drm/pl111/pl111_nomadik.c: In function 'pl111_nomadik_init': > drivers/gpu/drm/pl111/pl111_nomadik.c:34:9: error: implicit declaration of function 'drm_info'; did you mean 'pr_info'? [-Wimplicit-function-declaration] > 34 | drm_info(dev, "set Nomadik PMU mux to CLCD mode\n"); > | ^~~~~~~~ > | pr_info > > Fixes: a1542b8ca6ed ("drm: pl111: replace dev_* print functions with drm_* variants") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/pl111/pl111_nomadik.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/pl111/pl111_nomadik.c b/drivers/gpu/drm/pl111/pl111_nomadik.c > index f3218d59c5f1..0e5153deb1ac 100644 > --- a/drivers/gpu/drm/pl111/pl111_nomadik.c > +++ b/drivers/gpu/drm/pl111/pl111_nomadik.c > @@ -4,6 +4,7 @@ > #include > #include > #include > +#include > #include "pl111_nomadik.h" > > #define PMU_CTRL_OFFSET 0x0000 Thank you Arnd for catching this . It's my bad missed to compile with CONFIG_ARCH_NOMADIK config. Reviewed-by: Eslam Khafagy