From: patchwork-bot+netdevbpf@kernel.org
To: Ivan Vecera <ivecera@redhat.com>
Cc: netdev@vger.kernel.org, poros@redhat.com,
Prathosh.Satish@microchip.com, vadim.fedorenko@linux.dev,
arkadiusz.kubalewski@intel.com, jiri@resnulli.us,
kuba@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] dpll: zl3073x: fix memory leak on pin registration failure
Date: Thu, 21 May 2026 02:10:12 +0000 [thread overview]
Message-ID: <177932941239.3832404.17092382705971841087.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260519132205.161847-1-ivecera@redhat.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 19 May 2026 15:22:05 +0200 you wrote:
> If zl3073x_dpll_pin_register() fails, the allocated pin is not yet
> added to zldpll->pins list. The error path calls
> zl3073x_dpll_pins_unregister() which only iterates pins on the list,
> so the current pin is leaked. Free the pin before jumping to the error
> label.
>
> Additionally move the pin->dpll_pin = NULL assignment in
> zl3073x_dpll_pin_register() from err_register to the common
> err_pin_get path. When dpll_pin_get() fails, pin->dpll_pin holds an
> ERR_PTR value. Without this fix the subsequent zl3073x_dpll_pin_free()
> would trigger a spurious WARN because it checks pin->dpll_pin for
> non-NULL.
>
> [...]
Here is the summary with links:
- [net,v2] dpll: zl3073x: fix memory leak on pin registration failure
https://git.kernel.org/netdev/net/c/fa997ddef508
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-05-21 2:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 13:22 Ivan Vecera
2026-05-21 2:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177932941239.3832404.17092382705971841087.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=Prathosh.Satish@microchip.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=poros@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®