mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Cosmin Tanislav" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>,
	Thomas Gleixner <tglx@kernel.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org
Subject: [tip: irq/urgent] irqchip/renesas-rzv2h: Unwind on setup error
Date: Thu, 21 May 2026 09:50:33 -0000	[thread overview]
Message-ID: <177935703340.711.10070410285638178038.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260520201736.1509741-1-cosmin-gabriel.tanislav.xa@renesas.com>

The following commit has been merged into the irq/urgent branch of tip:

Commit-ID:     91f742be16497a435c929b3350d58b12acb16ce5
Gitweb:        https://git.kernel.org/tip/91f742be16497a435c929b3350d58b12acb16ce5
Author:        Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
AuthorDate:    Wed, 20 May 2026 23:17:36 +03:00
Committer:     Thomas Gleixner <tglx@kernel.org>
CommitterDate: Thu, 21 May 2026 11:48:30 +02:00

irqchip/renesas-rzv2h: Unwind on setup error

The call to rzv2h_icu_setup_irqs() may fail after the syscore ops have
been registered and the interrupt domain has been created. In that case, only
the runtime PM usage count is unwound.

Unregister the syscore ops and remove the interrupt domain on this error path.

Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260520201736.1509741-1-cosmin-gabriel.tanislav.xa@renesas.com
---
 drivers/irqchip/irq-renesas-rzv2h.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
index 31c543c..b11fa48 100644
--- a/drivers/irqchip/irq-renesas-rzv2h.c
+++ b/drivers/irqchip/irq-renesas-rzv2h.c
@@ -865,7 +865,7 @@ static int rzv2h_icu_probe_common(struct platform_device *pdev, struct device_no
 
 	ret = rzv2h_icu_setup_irqs(pdev, irq_domain);
 	if (ret)
-		goto pm_put;
+		goto unregister_syscore;
 
 	/*
 	 * coccicheck complains about a missing put_device call before returning, but it's a false
@@ -873,6 +873,9 @@ static int rzv2h_icu_probe_common(struct platform_device *pdev, struct device_no
 	 */
 	return 0;
 
+unregister_syscore:
+	unregister_syscore(&rzv2h_irqc_syscore);
+	irq_domain_remove(irq_domain);
 pm_put:
 	pm_runtime_put_sync(dev);
 	return ret;

  reply	other threads:[~2026-05-21  9:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 20:17 [PATCH] irqchip/renesas-rzv2h: unwind on IRQ " Cosmin Tanislav
2026-05-21  9:50 ` tip-bot2 for Cosmin Tanislav [this message]
2026-05-21  9:58   ` [tip: irq/urgent] irqchip/renesas-rzv2h: Unwind on " Cosmin-Gabriel Tanislav
2026-05-21 18:12     ` Thomas Gleixner
2026-05-27 10:51 ` [PATCH] irqchip/renesas-rzv2h: unwind on IRQ " Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177935703340.711.10070410285638178038.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=cosmin-gabriel.tanislav.xa@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®