From: patchwork-bot+netdevbpf@kernel.org
To: Zijing Yin <yzjaurora@gmail.com>
Cc: courmisch@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net] phonet/pep: disable BH around forwarded sk_receive_skb()
Date: Thu, 21 May 2026 14:50:17 +0000 [thread overview]
Message-ID: <177937501739.361786.17790917589741494228.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260519172635.86304-1-yzjaurora@gmail.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 19 May 2026 10:26:33 -0700 you wrote:
> The networking receive path is usually run from softirq context, but
> protocols that take the socket lock may have packets stored in the
> backlog and processed later from process context. In that case
> release_sock() -> __release_sock() drops the slock with spin_unlock_bh()
> and then calls sk->sk_backlog_rcv() with bottom halves enabled.
>
> Typical sk_backlog_rcv handlers process the socket whose backlog is
> being drained, so the BH state at entry is irrelevant for the slocks
> they touch. pep_do_rcv() is different: when the inbound skb targets an
> existing PEP pipe, it forwards the skb to a different *child* socket
> via sk_receive_skb(). That helper takes the child slock with
> bh_lock_sock_nested(), which is just spin_lock_nested() and assumes BH
> is already off. The same child slock therefore ends up acquired with
> BH on (process path) and with BH off (softirq path):
>
> [...]
Here is the summary with links:
- [net] phonet/pep: disable BH around forwarded sk_receive_skb()
https://git.kernel.org/netdev/net/c/dbc81608e3a6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-05-21 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 17:26 Zijing Yin
2026-05-20 11:53 ` Rémi Denis-Courmont
2026-05-20 13:48 ` Eric Dumazet
2026-05-21 14:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177937501739.361786.17790917589741494228.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=courmisch@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=yzjaurora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®