From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Axel Lin'" <axel.lin@ingics.com>,
"'Grant Likely'" <grant.likely@secretlab.ca>,
"'Linus Walleij'" <linus.walleij@linaro.org>
Cc: "'Thomas Abraham'" <thomas.abraham@linaro.org>,
"'Tomasz Figa'" <t.figa@samsung.com>,
linux-kernel@vger.kernel.org
Subject: RE: [PATCH RESEND] gpio: samsung: Add terminating entry for exynos_pinctrl_ids
Date: Mon, 25 Mar 2013 19:16:41 +0900 [thread overview]
Message-ID: <177a01ce2941$d843d420$88cb7c60$%kim@samsung.com> (raw)
In-Reply-To: <1363407672.3898.1.camel@phoenix>
Axel Lin wrote:
>
> The of_device_id table is supposed to be zero-terminated.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
I think, would be better if this could be sent to upstream via gpio tree now.
Thanks.
- Kukjin
> ---
> This patch was sent on https://lkml.org/lkml/2012/12/9/135
> Re-generate the patch against linux-next and resend.
>
> drivers/gpio/gpio-samsung.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index 99e0fa4..b22ca79 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -3030,6 +3030,7 @@ static __init int samsung_gpiolib_init(void)
> { .compatible = "samsung,exynos4x12-pinctrl", },
> { .compatible = "samsung,exynos5250-pinctrl", },
> { .compatible = "samsung,exynos5440-pinctrl", },
> + { }
> };
> for_each_matching_node(pctrl_np, exynos_pinctrl_ids)
> if (pctrl_np && of_device_is_available(pctrl_np))
> --
> 1.7.9.5
next prev parent reply other threads:[~2013-03-25 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-16 4:21 Axel Lin
2013-03-25 10:16 ` Kukjin Kim [this message]
2013-03-27 14:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='177a01ce2941$d843d420$88cb7c60$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=axel.lin@ingics.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®