From: David Heidelberg <david@ixit.cz>
To: Paul Sajna <sajattack@postmarketos.org>,
Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Nikita Travkin <nikitos.tr@gmail.com>,
Alexey Min <alexeymin@minlexx.ru>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 4/7] leds: aw2013: use dev_err_probe
Date: Sat, 10 Oct 2026 22:06:47 +0200 [thread overview]
Message-ID: <177c2c79-dcc5-4fad-8ffd-7ed3f4d3978c@ixit.cz> (raw)
In-Reply-To: <20261005-aw2013-aw20xx-rename-v2-4-108ecbdf2775@postmarketos.org>
On 06/10/2026 05:46, Paul Sajna wrote:
> Failure to use dev_err_probe() for regulator requests violates
> LED subsystem guidelines.
>
> The original driver didn't use it, but it's worth cleaning up
> while I'm here.
>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> drivers/leds/leds-aw2013.c | 28 +++++++++++++---------------
> 1 file changed, 13 insertions(+), 15 deletions(-)
>
Reviewed-by: David Heidelberg <david@ixit.cz>
next prev parent reply other threads:[~2026-10-10 20:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 3:46 [PATCH v2 0/7] leds: aw2013: Add AW2027 support Paul Sajna
2026-10-06 3:46 ` [PATCH v2 1/7] dt-bindings: leds: aw2013: Add awinic,aw2027 compatible Paul Sajna
2026-10-07 10:30 ` Conor Dooley
2026-10-06 3:46 ` [PATCH v2 2/7] leds: aw2013: Rename internal APIs from aw2013 to aw20xx Paul Sajna
2026-10-06 10:45 ` Griffin Kroah-Hartman
2026-10-06 18:54 ` Paul Sajna
2026-10-06 3:46 ` [PATCH v2 3/7] leds: aw2013: Add AW2027 support Paul Sajna
2026-10-06 3:46 ` [PATCH v2 4/7] leds: aw2013: use dev_err_probe Paul Sajna
2026-10-06 19:52 ` Griffin Kroah-Hartman
2026-10-07 7:36 ` Andreas Kemnade
2026-10-10 20:06 ` David Heidelberg [this message]
2026-10-06 3:46 ` [PATCH v2 5/7] leds: aw2013: Move assignment of chip->num_leds Paul Sajna
2026-10-06 3:46 ` [PATCH v2 6/7] leds: aw2013: Prevent writes to unpowered chip Paul Sajna
2026-10-06 3:46 ` [PATCH v2 7/7] leds: aw2013: move reset from probe_dt to chip_init Paul Sajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177c2c79-dcc5-4fad-8ffd-7ed3f4d3978c@ixit.cz \
--to=david@ixit.cz \
--cc=alexeymin@minlexx.ru \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=nikitos.tr@gmail.com \
--cc=pavel@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sajattack@postmarketos.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®