mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Xuanqing Shi <1356292400@qq.com>
Subject: Re: [PATCH v2] KVM: VMX: Handle bad values on proxied writes to LBR MSRs
Date: Fri, 29 May 2026 15:47:54 -0700	[thread overview]
Message-ID: <178009472610.881059.2932861959029055304.b4-ty@google.com> (raw)
In-Reply-To: <20260527022617.3973884-1-seanjc@google.com>

On Tue, 26 May 2026 19:26:17 -0700, Sean Christopherson wrote:
> Use the "safe" WRMSR API when writing LBRs on behalf of the guest (or host
> userspace), and propagate any errors back to the instigator, as the value
> being written is untrusted.  E.g. if the guest (or host userspace) attempts
> to set reserved bits in LBR_SELECT, then KVM needs to return an error, and
> not WARN on the bad value.
> 
> Continue using the "unsafe" version of RDMSR, as it should be impossible to
> reach the helper with a completely bogus MSR, i.e. WARNing on RDMSR failure
> is very desirable, e.g. to make KVM bugs more visible.
> 
> [...]

Applied to kvm-x86 vmx, thanks!

[1/1] KVM: VMX: Handle bad values on proxied writes to LBR MSRs
      https://github.com/kvm-x86/linux/commit/ca674df13b19

--
https://github.com/kvm-x86/linux/tree/next

      parent reply	other threads:[~2026-05-29 22:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27  2:26 Sean Christopherson
2026-05-27  2:59 ` 回复:[PATCH " 快乐豆豆
2026-05-29 22:47 ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178009472610.881059.2932861959029055304.b4-ty@google.com \
    --to=seanjc@google.com \
    --cc=1356292400@qq.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®