mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Thomas Gleixner" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Thomas Gleixner <tglx@kernel.org>,
	Arthur Kiyanovski <akiyano@amazon.com>,
	David Woodhouse <dwmw@amazon.co.uk>,
	thomas.weissschuh@linutronix.de,
	Jacob Keller <jacob.e.keller@intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/ptp] timekeeping: Add CLOCK_AUX support for ktime_get_snapshot_id()
Date: Thu, 04 Jun 2026 09:07:56 -0000	[thread overview]
Message-ID: <178056407671.710.770575418278241717.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260529195557.380601005@kernel.org>

The following commit has been merged into the timers/ptp branch of tip:

Commit-ID:     23c1bfa9f8dbefe0be1fa32aaf235c08cb24bd78
Gitweb:        https://git.kernel.org/tip/23c1bfa9f8dbefe0be1fa32aaf235c08cb24bd78
Author:        Thomas Gleixner <tglx@kernel.org>
AuthorDate:    Fri, 29 May 2026 22:00:24 +02:00
Committer:     Thomas Gleixner <tglx@kernel.org>
CommitterDate: Thu, 04 Jun 2026 11:04:16 +02:00

timekeeping: Add CLOCK_AUX support for ktime_get_snapshot_id()

Now that all users are converted it's possible to enable snapshotting of
CLOCK_AUX time. The underlying clocksource is the same as for all other
CLOCK variants.

Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Tested-by: Arthur Kiyanovski <akiyano@amazon.com>
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20260529195557.380601005@kernel.org
---
 kernel/time/timekeeping.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index a134b1b..e43aa11 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -67,6 +67,7 @@ static inline bool tk_is_aux(const struct timekeeper *tk)
 {
 	return tk->id >= TIMEKEEPER_AUX_FIRST && tk->id <= TIMEKEEPER_AUX_LAST;
 }
+static inline struct tk_data *aux_get_tk_data(clockid_t id);
 #else
 static inline bool tk_get_aux_ts64(unsigned int tkid, struct timespec64 *ts)
 {
@@ -77,6 +78,10 @@ static inline bool tk_is_aux(const struct timekeeper *tk)
 {
 	return false;
 }
+static inline struct tk_data *aux_get_tk_data(clockid_t id)
+{
+	return NULL;
+}
 #endif
 
 static inline void tk_update_aux_offs(struct timekeeper *tk, ktime_t offs)
@@ -1218,6 +1223,12 @@ void ktime_get_snapshot_id(clockid_t clock_id, struct system_time_snapshot *syst
 		tkd = &tk_core;
 		offs = &tk_core.timekeeper.offs_boot;
 		break;
+	case CLOCK_AUX ... CLOCK_AUX_LAST:
+		tkd = aux_get_tk_data(clock_id);
+		if (!tkd)
+			return;
+		offs = &tkd->timekeeper.offs_aux;
+		break;
 	default:
 		WARN_ON_ONCE(1);
 		return;
@@ -1228,6 +1239,10 @@ void ktime_get_snapshot_id(clockid_t clock_id, struct system_time_snapshot *syst
 	do {
 		seq = read_seqcount_begin(&tkd->seq);
 
+		/* Aux clocks can be invalid */
+		if (!tk->clock_valid)
+			return;
+
 		now = tk_clock_read(&tk->tkr_mono);
 		systime_snapshot->cs_id = tk->tkr_mono.clock->id;
 		systime_snapshot->cs_was_changed_seq = tk->cs_was_changed_seq;

  parent reply	other threads:[~2026-06-04  9:07 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29 19:59 [patch V2 00/25] timekeeping/ptp: Expand snapshot functionality Thomas Gleixner
2026-05-29 19:59 ` [patch V2 01/25] timekeeping: Provide ktime_get_snapshot_id() Thomas Gleixner
2026-06-02  9:46   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-05-29 19:59 ` [patch V2 02/25] timekeeping: Use system_time_snapshot::systime/monoraw instead of ::real/raw Thomas Gleixner
2026-06-02  9:46   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-05-29 19:59 ` [patch V2 03/25] pps: generators: Use ktime_get_real_ts64() instead of ktime_get_snapshot() Thomas Gleixner
2026-05-30 11:04   ` Rodolfo Giometti
2026-06-02  9:46   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 04/25] pps: Convert to ktime_get_snapshot_id() Thomas Gleixner
2026-05-30 11:08   ` Rodolfo Giometti
2026-06-02  9:31     ` Thomas Gleixner
2026-06-02 10:56       ` David Woodhouse
2026-06-02  9:46   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 05/25] KVM: arm64: Use ktime_get_snapshot_id() to retrieve CLOCK_BOOTTIME Thomas Gleixner
2026-06-02  9:46   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  1:55     ` Nathan Chancellor
2026-06-04  9:06       ` Thomas Gleixner
2026-06-04  9:08   ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 06/25] KVM: arm64: Use ktime_get_snapshot_id() to snapshot CLOCK_REALTIME Thomas Gleixner
2026-06-02  9:46   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:08   ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 07/25] ptp: ptp_vmclock: Convert to ktime_get_snapshot_id() Thomas Gleixner
2026-06-02  9:46   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:07   ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 08/25] timekeeping: Remove system_time_snapshot::real/boot/raw Thomas Gleixner
2026-06-02  9:46   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:07   ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 09/25] timekeeping: Add CLOCK_AUX support for ktime_get_snapshot_id() Thomas Gleixner
2026-06-02  9:46   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:07   ` tip-bot2 for Thomas Gleixner [this message]
2026-05-29 20:00 ` [patch V2 10/25] timekeeping: Add system_counterval_t to struct system_device_crosststamp Thomas Gleixner
2026-06-02  9:46   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:07   ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 11/25] timekeeping: Add CLOCK ID to system_device_crosststamp Thomas Gleixner
2026-06-02  9:46   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:07   ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 12/25] wifi: iwlwifi: Adopt PTP cross timestamps to core changes Thomas Gleixner
2026-06-02  9:46   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:07   ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 13/25] ice/ptp: Use provided clock ID for history snapshot Thomas Gleixner
2026-06-02  9:46   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:07   ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 14/25] igc: " Thomas Gleixner
2026-06-02  9:46   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:07   ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 15/25] net/mlx5: " Thomas Gleixner
2026-06-02  9:46   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:07   ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 16/25] virtio_rtc: " Thomas Gleixner
2026-06-02  9:45   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-02 14:44   ` [patch V2 16/25] " Peter Hilber
2026-06-04  9:07   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 17/25] timekeeping: Remove ktime_get_snapshot() Thomas Gleixner
2026-06-02  9:45   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:07   ` tip-bot2 for Thomas Gleixner
2026-05-29 20:01 ` [patch V2 18/25] timekeeping: Prepare for cross timestamps on arbitrary clock IDs Thomas Gleixner
2026-06-02  9:45   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:07   ` tip-bot2 for Thomas Gleixner
2026-06-22  8:55   ` [patch V2 18/25] " David Woodhouse
2026-06-22 11:07     ` Thomas Gleixner
2026-06-22 12:34       ` David Woodhouse
2026-05-29 20:01 ` [patch V2 19/25] ptp: Use system_device_crosststamp::sys_systime Thomas Gleixner
2026-06-02  9:45   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:07   ` tip-bot2 for Thomas Gleixner
2026-05-29 20:01 ` [patch V2 20/25] wifi: iwlwifi: " Thomas Gleixner
2026-06-02  9:45   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:07   ` tip-bot2 for Thomas Gleixner
2026-05-29 20:01 ` [patch V2 21/25] ALSA: hda/common: " Thomas Gleixner
2026-06-02  9:45   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-02 17:46   ` [patch V2 21/25] " Takashi Iwai
2026-06-04  9:07   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-05-29 20:01 ` [patch V2 22/25] timekeeping: Remove system_device_crosststamp::sys_realtime Thomas Gleixner
2026-06-02  9:45   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:07   ` tip-bot2 for Thomas Gleixner
2026-05-29 20:01 ` [patch V2 23/25] timekeeping: Add support for AUX clock cross timestamping Thomas Gleixner
2026-06-02  9:45   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:07   ` tip-bot2 for Thomas Gleixner
2026-05-29 20:01 ` [patch V2 24/25] ptp: Switch to ktime_get_snapshot_id() for pre/post timestamps Thomas Gleixner
2026-06-02  9:45   ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04  9:07   ` tip-bot2 for Thomas Gleixner
2026-05-29 20:01 ` [patch V2 25/25] timekeeping: Add clocksource read_snapshot() method and hw_cycles to snapshot Thomas Gleixner
2026-06-02  9:45   ` [tip: timers/ptp] " tip-bot2 for David Woodhouse
2026-06-04  9:07   ` tip-bot2 for David Woodhouse
2026-05-29 20:33 ` [patch V2 00/25] timekeeping/ptp: Expand snapshot functionality Jacob Keller
2026-06-01 10:59 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178056407671.710.770575418278241717.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=akiyano@amazon.com \
    --cc=dwmw@amazon.co.uk \
    --cc=jacob.e.keller@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=tglx@kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®