From: patchwork-bot+netdevbpf@kernel.org
To: David CARLIER <devnexen@gmail.com>
Cc: netdev@vger.kernel.org, noreply@anthropic.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, kees@kernel.org,
tglx@kernel.org, zhaoyz24@mails.tsinghua.edu.cn,
mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: garp: reload skb header pointers after pskb_may_pull()
Date: Tue, 09 Jun 2026 02:20:05 +0000 [thread overview]
Message-ID: <178097160539.1758231.18195055123313838139.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260604141925.237746-1-devnexen@gmail.com>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 4 Jun 2026 15:19:22 +0100 you wrote:
> garp_pdu_parse_attr() keeps a pointer into the skb linear area across
> pskb_may_pull(skb, ga->len), and garp_pdu_parse_msg() dereferences gm
> on every loop iteration even though the nested parse may pull again.
> pskb_may_pull() can reallocate the skb head, which would leave those
> pointers stale.
>
> This is not reachable today: GARP PDUs arrive via the 802.2 LLC SAP
> path, where llc_fixup_skb() already pulls and trims the whole payload
> into the linear area, so the inner pulls never reallocate. Reload ga
> after the pull and snapshot gm->attrtype into a local anyway, to harden
> the parser and match the skb_header_pointer() discipline used by mrp.c.
>
> [...]
Here is the summary with links:
- net: garp: reload skb header pointers after pskb_may_pull()
https://git.kernel.org/netdev/net-next/c/ab71cf79e2f8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-06-09 2:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 14:19 David Carlier
2026-06-09 2:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178097160539.1758231.18195055123313838139.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=devnexen@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noreply@anthropic.com \
--cc=pabeni@redhat.com \
--cc=tglx@kernel.org \
--cc=zhaoyz24@mails.tsinghua.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome