From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BA7E374190 for ; Tue, 9 Jun 2026 16:25:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781022324; cv=none; b=T3eGrqcSCJWLzWhhvUwk/6xA565GReNlaovqekqbWXtferZD3HVmCOMZK+YQWQsK1BJrgdua/O6dT+9cOnXMWsdXdlSeI74qbPCwwM7f9x0xbfiFnhfDcGGmgPn7auQdM3avt5ekTMYCh+gZgy9ozBMMFn7DJ1nFrlJ9gejBhfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781022324; c=relaxed/simple; bh=Jh1ZE5uq78gnZxkFGh13lMr8+RRPEWEpeWd+HMx066U=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=dInbsKka0e67hbe1GEBkUfaZfAffrlSTl9i5eSSRam8XYw5adyiwVF5vCJ0Mu7Qod4FP40l+FhFstiEPufNDN1Opy2JbNCyvotCfQVQrEAV8di0dmQgugGrGYBiqB9Icqc6LE7ZDLZbNBvMVALVxG4i2YpbCA7NayfuRZgzEn7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TAWczO2a; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HU7J/tt6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TAWczO2a"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HU7J/tt6" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 659GOmps2785577 for ; Tue, 9 Jun 2026 16:25:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gZ0RRpoiTcyO43kD7baXaPj3wcmkJLLGJPD4QWeYn7c=; b=TAWczO2aidQaIoXM CC2ktMv8IynppxZsasLjjfJ52g3otyjQyn/MsteSYkqsWxvFBXVnBolc+LeiPa4g OZLGof7YuybsJVv8LAqENi9JSGzTdn0d+eDbOCuDOZPN0yMtyJ0S+1SEySIjJxBM lstghTt3DsUuQfhoaijNrGd/X5SQjQ3TgGA/wzwYX1J9zaWDoBafp3gHiyjH+Ufw jxmkuF3jXWwr5BMmU41FH/oHi7d0Oq5LLIYWvEDmKOisU2IWMHYd5/M0ZLjaPxcE lncCTIWfn2KQq0U80eAQNVczYw2UFVSmYdK1fwqdklgHGtswSh3FgTaR+d9NbjAL IQ3mVw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epg3jt3r3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 16:25:22 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-36b9106b0fbso4646732a91.0 for ; Tue, 09 Jun 2026 09:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781022322; x=1781627122; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gZ0RRpoiTcyO43kD7baXaPj3wcmkJLLGJPD4QWeYn7c=; b=HU7J/tt6UYgC4HUH/M7oHcZs5yD/K6wGoJzepNVVgGPyzEwO69mb99OJbHYm6C94Jc b2KBZSPr0PfjotsYNOqK7klf1fOMX+w+vjYP2280kj6CZcrMXrDT+O7LznMN4owMX730 Di/oA/aDZTaSOgeDlcSfKY/S7cGj9a3kprBVYuxRAP+Tob8PK1QnyyMCJ+zuR5tWi8dQ rrXSlII417Hxy7T90bvGfql3plPv3f3iXtJ31nndR++HTy6Jf5EXNUpSp1ASptVA1sHc 1YwjVE6w9qjvCVTfnxhMmqni/MyxTrWNbXLxTHDkPzouq6scGyGDDdhF1ue17tcdBOR5 5R6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781022322; x=1781627122; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gZ0RRpoiTcyO43kD7baXaPj3wcmkJLLGJPD4QWeYn7c=; b=KZAq9jnk92qmrPwMoSEcuBoFCqf3R4Mm1gIIwTjeXlebugxn6loaek6HrUCxN7Tc7J bOauMqASmM0dn3qwQhyDUCUOvRzvSrS0DlMhFy6S7FoGdevTREzmtXZmUHkZPL720Qqc 2sb5w3m/PYPRJIiiaOA1wFEvu7nhQmmiJ3pA+uqC5USmx679Yu5ZfZJ7MO6HblJVVAuC dYojMVAB7B4TzB006M+aW3yJnfm69yCu2gSvQM7zBfS0WViMPFIQVPvPfKXxS+2iUlcP 1HvXkl5XTsJ8X3NTwQlLwRM+a6tsgm2WOhWMXL8GV4RyL+18gYXYoO2KHDkaGXMVAp7H XSiQ== X-Forwarded-Encrypted: i=1; AFNElJ/zrnd5+Yblf648PPnOgYWqO3tEzJNhRaHCaxZxLEMtn8147lY9/L7Uvo/Gt6ivpQxQvmz0o7N0lfUg/Xs=@vger.kernel.org X-Gm-Message-State: AOJu0YwUTifA4geo68Jg93MsyjBkytVLQr+6zwOTsIWhuO8KALwHT4SP Zo4mLuwiW3VuMoxG/bsvHMDnfoQMkhZzCsxqr19ExJRlA9J4D94RaKkAvdoSyuspg4L32DvwxD2 PxPkDYshHPZ67NRxHBgQAtbV+0RGZtRzpwQKISCvREwtTUYZX4tPTmzqIAcH464MSaJE= X-Gm-Gg: Acq92OG4tigzHse7ofIwH2ifu6YVVjmgItZu1Xogi2pP4nisHCSS7L9ENLleGTE5XSC BsZRs5WFyw6y3dazGsM8M8X+L3xso+7QWmqMIek+Ko6ng2BhOmDCj/+Vyl+Y//l+LMC21ICqBaQ xUnCwMT9sr4QtLf2Bd0XAq9aT82bi/MBoO9WrM0M1R/EDTqVRxe6JXle2GgYJ6o/KkCeRqU1oYB IGPk2n3rrmjX9sazT+bjBugYBVnS1DsO51J+bWXBnWXKlDQD7MgoXVutDi8otYnNsCZvxBp3/qz cXqS37lO7yaumxhsGElgiymYFbn7MV5yhHBsK8DX1EqvOjnkSVGuqrhdoNQuOb4BhJBW9PWabE0 texF1z/YMpIHCzrY4FEaGzJBr6/qrzTo= X-Received: by 2002:a17:90b:3903:b0:36b:4d63:4a93 with SMTP id 98e67ed59e1d1-371328ae3c0mr17914262a91.13.1781022321819; Tue, 09 Jun 2026 09:25:21 -0700 (PDT) X-Received: by 2002:a17:90b:3903:b0:36b:4d63:4a93 with SMTP id 98e67ed59e1d1-371328ae3c0mr17914221a91.13.1781022321282; Tue, 09 Jun 2026 09:25:21 -0700 (PDT) Received: from [192.168.1.11] ([120.56.203.186]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6bf827e6sm24900815a91.1.2026.06.09.09.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 09:25:20 -0700 (PDT) From: Manivannan Sadhasivam X-Google-Original-From: Manivannan Sadhasivam To: Yue Wang , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Shuvam Pandey Cc: linux-pci@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: <177909148011.9588.6639767953842842291@gmail.com> References: <177909148011.9588.6639767953842842291@gmail.com> Subject: Re: [PATCH] PCI: meson: Propagate devm_add_action_or_reset() failure Message-Id: <178102231651.11622.14383228802721431855.b4-ty@kernel.org> Date: Tue, 09 Jun 2026 21:55:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-Proofpoint-GUID: 66C0ml0FMzWQBmshGsBpXha5_0j2o1-7 X-Authority-Analysis: v=2.4 cv=aa9RWxot c=1 sm=1 tr=0 ts=6a283e72 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=eDurORsI8St+1bJHqsJewQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=YIal6LhKh1zn__LXBV8A:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDE1NSBTYWx0ZWRfX1skUm8Evn8TT wLrsq0xk49Qnb+rb4V+rMmkmPmfUoZCP5RbNiClUQf+Vs0KhinCUw7jBHaipyUy6YfER54g1ZrW Z+qrDlgOPvdGZRVRiO6kojXmqzI8J2UVzCqE20dxY351pKedZr2YXiTeEBs7VIz7PZS4txsTMyQ nQdE7hpGY3z7WlUqvPiCls3lRBEmOgINIw5Qs6udfCY79OONGIf15uJBkJtl1jJGpuXplawg0HS 3ZwI7iG8eozf4tHOR4BA1YHIQLVYEdkqqrjpYz1IX7FtHWV90EDmIUzyPIWlX10VMElfdY4yJcT jBTuoE7shW7HXK1XPe+kzzBA9eYJ2OKct9Urm/BkEUTMcO9KjHG+Oq/RfKcuAUc3d5jXc/gF7Ep uwVxTCabsLTP4iWNKDnlB85c/C1qoPrm3aYeBAyp+9MYel0UTdWAtaHQx6Igh63Z0uYkgvfVuIQ ixWjAvrkzaUMBG3S33w== X-Proofpoint-ORIG-GUID: 66C0ml0FMzWQBmshGsBpXha5_0j2o1-7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_04,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090155 On Mon, 18 May 2026 13:49:40 +0545, Shuvam Pandey wrote: > meson_pcie_probe_clock() enables a clock and then registers a devres > action to disable it during teardown. If devm_add_action_or_reset() > fails, it runs the action immediately, disabling the clock. > > The return value is currently ignored, so on that failure path > meson_pcie_probe_clock() returns the disabled clock and probe continues. > Return the error so the existing probe error path unwinds normally. > > [...] Applied, thanks! [1/1] PCI: meson: Propagate devm_add_action_or_reset() failure commit: b12341b98d5ac52f48ca1390e1e371aed81346c8 Best regards, -- Manivannan Sadhasivam