From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752199AbbKJMJJ (ORCPT ); Tue, 10 Nov 2015 07:09:09 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:60062 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751111AbbKJMJH (ORCPT ); Tue, 10 Nov 2015 07:09:07 -0500 From: Arnd Bergmann To: Pablo Neira Ayuso Cc: Patrick McHardy , Jozsef Kadlecsik , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, Ken-ichirou MATSUZAWA , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] netfilter: nfnetlink_log: work around uninitialized variable warning Date: Tue, 10 Nov 2015 13:08:15 +0100 Message-ID: <17817903.Md6b3ydRpX@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:rAUVO00w27ZmJqB23e0LyVYeCyHmBqKQiz9jhApcvMkMuo9lg7e LJtdflECt2Y28vlo2Sg3viHvsAbXQzhUUJ+9UIrMFGAszyyA5GYPm+ZA5dGWY3r+s9PMPpP vVKr2IDd+98Mhx5BxFrZNHCRuWaFT+dL5/koKRoA/SpT3iaZpYXHk8fIQYMteiJJjt57/Kw MikPeoNlvgd2lhCd1zHKQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:LXtFfZHq6NU=:8mQ7VrHh+RURdid+pU3acX ujuR7Bfa5DCBdkADBERVUXxg0Oat9MfS34mC7JqoCgFauX0PdxiUNFR2U4XsHfZFpJSztW36t /NVFTRWjIFpHzSxe5clTRlYO0NO+KQn7k7pO6tn8wkAS1iC4brudq/oe0qctbJXU1bzSikgWo dzPRpi/gNplF7FaytbMMymJ2NhrNa36o/AltfOyoytYNGV/i7OM1AeriVZ2teWScXZkrnPR4j xKTC05j//Y+bmn0xZnKE88ZKgCGXjvWS94uNFN8QoEp+eQFMgLhqXCBTTAu75XwCSew6asl17 YBlU8wQIbFJ/4saBQm6KRguU8G+BCmVEDKgH2FChQHAlA8cKK6afvqcDPj7HZtjq62ESG6FMt 0IOX6hF05kWmifPTd7pVG2GyoeQHrTgc/S6CkwcKpcdMi9eRJ9uSADVwEjCWID4TYSdwzmwBI b8wUDiY0S9fy+x2HVUohZbvSgtmdDS9WuZIlQkgc63wRq2xLSX5+Dl78Sg+lDIX16P62o2l7k l5oY4fmP6JxJDjyI2F67SuOOnUFm+xegoRGyzeYKH2Ac0wn/dS2oOfGYxO/khfFz9uSf/o3lk S8C/3/vN2LG9gM3Wgcsk0g5CNhQFgs6KyexsOOl+vSN+GNxf6qQthMVxV5EqWllKLUhrRiFrl WH8wNeSXY5Yc8l0Fo0C6/kDai931V5FyyNIsK2wK79PFgbIt4D8i3tARaqE4Nrt7vfWvN9cZ4 ySP1TpM0dMaepDTm Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After a recent (correct) change, gcc started warning about the use of the 'flags' variable in nfulnl_recv_config() net/netfilter/nfnetlink_log.c: In function 'nfulnl_recv_config': net/netfilter/nfnetlink_log.c:320:14: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] net/netfilter/nfnetlink_log.c:828:6: note: 'flags' was declared here The warning first shows up in ARM s3c2410_defconfig with gcc-4.3 or higher (including 5.2.1, which is the latest version I checked) I tried working around it by rearranging the code but had no success with that. As a last resort, this initializes the variable to zero, which shuts up the warning, but means that we don't get a warning if the code is ever changed in a way that actually causes the variable to be used without first being written. Signed-off-by: Arnd Bergmann Fixes: 8cbc870829ec ("netfilter: nfnetlink_log: validate dependencies to avoid breaking atomicity") --- diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c index 06eb48fceb42..740cce4685ac 100644 --- a/net/netfilter/nfnetlink_log.c +++ b/net/netfilter/nfnetlink_log.c @@ -825,7 +825,7 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb, struct net *net = sock_net(ctnl); struct nfnl_log_net *log = nfnl_log_pernet(net); int ret = 0; - u16 flags; + u16 flags = 0; if (nfula[NFULA_CFG_CMD]) { u_int8_t pf = nfmsg->nfgen_family;