From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760053Ab3DBMhU (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Apr 2013 08:37:20 -0400
Received: from hydra.sisk.pl ([212.160.235.94]:50065 "EHLO hydra.sisk.pl"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1759837Ab3DBMhR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Apr 2013 08:37:17 -0400
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-i2c@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
        Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH] ACPI / I2C: Use parent's ACPI_HANDLE() in acpi_i2c_register_devices()
Date: Tue, 02 Apr 2013 14:44:51 +0200
Message-ID: <1781994.sa3Syq0Q4W@vostro.rjw.lan>
User-Agent: KMail/4.9.5 (Linux/3.9.0-rc4+; KDE/4.9.5; x86_64; ; )
In-Reply-To: <20130402045105.GA17682@the-dreams.de>
References: <2966020.zlpeyGGUDW@vostro.rjw.lan> <20130402045105.GA17682@the-dreams.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, April 02, 2013 06:52:37 AM Wolfram Sang wrote:
> On Mon, Apr 01, 2013 at 02:25:03AM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > 
> > The ACPI handle of struct i2c_adapter's dev member should not be
> > set, because this causes that struct i2c_adapter to be associated
> > with the ACPI device node corresponding to its parent as the
> > second "physical_device", which is incorrect (this happens during
> > the registration of struct i2c_adapter).  Consequently,
> > acpi_i2c_register_devices() should use the ACPI handle of the
> > parent of the struct i2c_adapter it is called for rather than the
> > struct i2c_adapter's ACPI handle (which should be NULL).
> > 
> > Make that happen and modify the i2c-designware-platdrv driver,
> > which currently is the only driver for ACPI-enumerated I2C
> > controller chips, not to set the ACPI handle for the
> > struct i2c_adapter it creates.
> > 
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Shall this go via the I2C tree? If not, for the I2C part:

Well, I'm going to push it through the ACPI/PM tree, if that's not a problem
along with an analogous SPI patch.

> Acked-by: Wolfram Sang <wsa@the-dreams.de>

Thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.