From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 461B6344D92 for ; Mon, 22 Jun 2026 18:28:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782152929; cv=none; b=RJAl4lx9vnhdIccte0Q7WLisC2hs7nGDbOgTf16S1jI6wmmiu0AO5AKdSoYCrWYBUJ/8qd3G1a5wz3jOFAt6Ct3tqSsWgoB9bTqd/EMYHjPqUF9kFz3X/l2DPXMNl1+3fWRpUwVgNaB8S019xeBlP4ovgyT42bl+xplzGRdUy14= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782152929; c=relaxed/simple; bh=SGBlUrE1CYvkAsoFhupgwqHbmryO09vV1weN5LC6u7s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=N9SnLxWbPNziEk0kaObPle/89JBoyU0dxrHaBw+6o7n544a3dPIVgNoXXnMyFsafv/mXMdk0Vo699Dmzb7wHUxQ+OE72gOq/7MQFk/iplOysNroQpXxLVbN+bF++qDK3XQVGA5xDenbyJz1bWPLSAABSz514Fw5uWmGXILmnRe0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jdu/ilGG; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jdu/ilGG" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-490a76757e5so30022235e9.2 for ; Mon, 22 Jun 2026 11:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782152927; x=1782757727; darn=vger.kernel.org; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SGBlUrE1CYvkAsoFhupgwqHbmryO09vV1weN5LC6u7s=; b=jdu/ilGGtSDoUAWmc+6mLjWauz3JMfS1Edwms05imqq/cY6m7A0Ku2NPnNE8DCwKiQ 5UYbIMX6mKe6Q4w8eab8qfAmAPtybf07VoMNdPwR7DJ0WrzWE5o/HRbIC7OVNQhTF63u 33eOPli07q/ucJSWiFadFd8wKx9LE6eN4x7XrjSEhu80A2qwK18BZ2KF9Z/YFOUogGlw evrhfwAkInc6mjYLzJSkjH05PDf0mrPy3j0wygAGBpv9kSKns3yM1gBptaRFXoCs+d8n 2n9P1Fsg6g+7IdtZVWeDUHTirOFkBWM3O5cwGZtg9g+1fylTilOmnTQMwoIP/iNe2HcL 8Dvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782152927; x=1782757727; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SGBlUrE1CYvkAsoFhupgwqHbmryO09vV1weN5LC6u7s=; b=TL6wEqVtxjqLv8R3nMr8B+LHYqOboZym6ZIyyA+403nN4vZ1/W3o3UNzV/aTx7b8R8 aJu1jtxsD8b9jC0Ybc3DhlsrlL+o3omR19viPzjEKNCRoT9kwPbBayoeRGwxt3EBdFam Zg5zx4qhov+VrzCN87Ol2QfIi6eXE49MrkvXVI96nSwcdD7cB7iz2zfUe9vx3yvNUq/c iSWqI2xg23TDMuDBeTZ2ZNittTfEIMyuHuS2KWqasLdLm0UHTBvZn2Aq775At8dP1Q8w y5Hdmm0hH3oyz7bSJMSyXYN1pMNpjrgQsVdJ3cpJKeQFIJsOtn0bx/VqkAUQHMC9TSi6 YZOw== X-Forwarded-Encrypted: i=1; AFNElJ8QTtg/ryuiHxgKQv5rAPv6yZN+iRFDsIfdhXUdncsEoJB+RBSHeWgRgynxDo0MSFNcxmDdCYBwGIu4fQg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywaja+cAb3wCkbX7giCJqnltLWTXqLFuXF++vDRLI+WI1P+rSVJ QPwttQp2luxKj5SCytHapsdJIECA0lYv5Em3V9p3pxv+O5J8zraeeeLOQoQiHZU= X-Gm-Gg: AfdE7cmp+OcOweSOT7KGfQg68qslUUUSEoQgSOk+JYAXjWDTgOROqAbrgH2LOXMQvBX EK7vulf2MXtfSImhlnS3xwM+cFSCfLELKVFRUWuUUwMQL4R5Cdvnr1ixJ2O5gd5Sxx7tDenuge+ KCsa2Sib2SaeMwMxWLbAvekhpXOHUN/6yZOlV3JT3uPGmuDkY15vRugmJWLAzUcKz4Q9t0jZ94c CQNG116YhCWgi9zauqJZ9wklu1Gdl1nPj0KWhrfeJmmWQMnOqaZ3kfNsrxvMbNbtgPJKj59ND2o dG6wzCTO3cOK0hAy5juRebhWPuZYU6lxH/VUFX81aFX5CJRTRz//zBa5KKNDwhzmnq5VsqrlHr/ YJ2UQ91SbhilFfOR5eBux2QZhtTUXH+mxmV/+iVczrIw652AopK6HKwJ+d03c6fwYQN62kfUVQm GH2a2iIDg54Lityt+BrMjzk3ntMXI= X-Received: by 2002:a05:600c:638e:b0:490:c024:2ec8 with SMTP id 5b1f17b1804b1-4923eea91efmr253997895e9.0.1782152926404; Mon, 22 Jun 2026 11:28:46 -0700 (PDT) Received: from kali (88-170-213-78.subs.proxad.net. [88.170.213.78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-466667882f7sm29067783f8f.21.2026.06.22.11.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 11:28:45 -0700 (PDT) From: Tristan Madani To: Tetsuo Handa , Andrew Morton Cc: Dave Hansen , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Tristan Madani Subject: Re: [PATCH v2] profiling: don't free prof_cpu_mask on init failure Date: Mon, 22 Jun 2026 18:28:45 -0000 Message-ID: <178215292501.1603617.6905680542049189509@gmail.com> In-Reply-To: References: <20260622000022.3375262-1-tristmd@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On 2026/06/22 20:32, Tetsuo Handa wrote: > Why 22b8ce94708f ? That commit did not add free_cpumask_var(). > Since free_cpumask_var() was removed by 7c51f7bbf057, your patch might want > explanation about why you choose to only avoid UAF-read for stable kernels > instead of try to apply 7c51f7bbf057. Thanks for the review. You're right, the Fixes tag should be c309b917cab5 ("cpumask: convert kernel/profile.c"). I went with the minimal fix you suggested since 7c51f7bbf057 touches two files and adds serialization, which felt heavier for a stable backport. Would a v3 with the corrected Fixes tag and a note explaining the choice over 7c51f7bbf057 work, or would you prefer to just Cc stable on your commit? Tristan