From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Damjan Georgievski <gdamjan@gmail.com>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Hans de Goede <johannes.goede@oss.qualcomm.com>,
Kate Hsuan <hpa@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Serin Yeh <serin.yeh@intel.com>,
Tarang Raval <tarang.raval@siliconsignals.io>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Kate Hsuan <hpa@redhat.com>
Subject: Re: [PATCH v5 3/3] media: i2c: imx471: Add Sony IMX471 image sensor driver
Date: Wed, 24 Jun 2026 14:08:40 +0100 [thread overview]
Message-ID: <178230652068.3075020.18062205400239666843@ping.linuxembedded.co.uk> (raw)
In-Reply-To: <20260624033508.27391-4-hpa@redhat.com>
Hi Kate,
Quoting Kate Hsuan (2026-06-24 04:35:08)
> Add a new driver for Sony imx471 camera sensor. It is based on
> Jimmy Su <jimmy.su@intel.com> implementation and the driver can be found
> in the following URL.
> https://github.com/intel/ipu6-drivers/commits/master/drivers/media/i2c/imx471.c
>
> This sensor can be found on Lenovo X1 Carbon G14, X9-14 and X9-15 laptops
> and it is a part of IPU7 solution. The driver was tested on Lenovo X1
> Carbon G14, X9-14 and X9-15 laptops.
>
> Signed-off-by: Kate Hsuan <hpa@redhat.com>
> ---
... <snip>
> +#define IMX471_REG_EXCK_FREQ CCI_REG16(0x0136)
> +#define IMX471_EXCK_FREQ(n) ((n) * 256) /* n in MHz */
>
<snip>
> +
> +static const struct cci_reg_sequence imx471_global_regs[] = {
> + { IMX471_REG_EXCK_FREQ, IMX471_EXCK_FREQ(19.2) },
Does this work? Is this a compile time constant multiplying floating
point with the compiler, or something happening in the kernel?
I'll be happy if it does, but it catches my attention as something I
thought we couldn't do.
--
Kieran
next prev parent reply other threads:[~2026-06-24 13:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 3:35 [PATCH v5 0/3] Add Sony IMX471 camera " Kate Hsuan
2026-06-24 3:35 ` [PATCH v5 1/3] media: ipu-bridge: Add DMI information of Lenovo X9 to the image upside-down list Kate Hsuan
2026-06-24 3:35 ` [PATCH v5 2/3] media: ipu-bridge: Add Sony IMX471 for Lenovo X1 Carbon G14 Kate Hsuan
2026-06-24 3:35 ` [PATCH v5 3/3] media: i2c: imx471: Add Sony IMX471 image sensor driver Kate Hsuan
2026-06-24 8:43 ` Tarang Raval
2026-06-24 9:08 ` Kate Hsuan
2026-06-24 9:58 ` Tarang Raval
2026-06-24 10:01 ` Sakari Ailus
2026-06-25 3:55 ` Kate Hsuan
2026-06-24 8:55 ` Sakari Ailus
2026-06-24 9:30 ` Kate Hsuan
2026-06-24 10:02 ` Sakari Ailus
2026-06-24 10:12 ` Vladimir Zapolskiy
2026-06-25 5:36 ` Kate Hsuan
2026-06-24 13:08 ` Kieran Bingham [this message]
2026-06-24 14:06 ` Tarang Raval
2026-06-25 5:46 ` Kate Hsuan
2026-06-26 18:10 Anis TALBI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178230652068.3075020.18062205400239666843@ping.linuxembedded.co.uk \
--to=kieran.bingham@ideasonboard.com \
--cc=gdamjan@gmail.com \
--cc=hpa@redhat.com \
--cc=hverkuil+cisco@kernel.org \
--cc=johannes.goede@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=serin.yeh@intel.com \
--cc=tarang.raval@siliconsignals.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®