From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E35520DD51 for ; Thu, 25 Jun 2026 23:46:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782431167; cv=none; b=rqayWcLemd6D65gFFiLWWA8TGYvNPDHPmz5dpFY1lViE7W1wVYXnYEvqD2pZqs+jRoZmrtwfjHPqV2h12lcI/R6sd0WfWNzNsMFizZOGc1BqJEhxSNgT5rTm/dWVA/jqJM3MvAshjAffdAAZ9495HX5vdmP+VUdmAZPQ6SoWNzM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782431167; c=relaxed/simple; bh=jnIzd9eXyM0lY5nLSKWOGJM4W2fxtczCL/IrCKu34m8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=uwEICp3GYMnlo0CBIv77WC63jyTxiZr+uk6MM9UlnKXS++lN0cnMsxDKfLYdE/beqIa1HQiFpaB2AT5zBnQWImz0MNucxfrzv2D3GpD+Z2oyIGGkND3Td0DP0UoyRXQY9bQtpZ5UL96HERzO0+gloKYGOfcYV9ya3KtZpxt4FFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QKbuiSZo; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QKbuiSZo" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-490b3637b90so2380035e9.3 for ; Thu, 25 Jun 2026 16:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782431165; x=1783035965; darn=vger.kernel.org; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jnIzd9eXyM0lY5nLSKWOGJM4W2fxtczCL/IrCKu34m8=; b=QKbuiSZosEQxQUhbQggRt8UItfhFDmC0tLrLcEL51qtr5EgnZSEtpeEZFqUyzXMXvT 2d1LKTAq7z9sEbhQrJuBb9uHvJrvksZkeMoKZwZz8Bi9OI5N2aQJLxduu5Nzkn8UpYko hSlOhNYr30cD/m+G15lesKfFbbVcZxcIpw73hz3iLW77WmdbLSeFEfhAJXL7LAQiLM+M 1nY1u8m9xhRVrT4Pds7Q/QI2i4O2BURUIzRQJP/F0L15PzDzXH5k3wrVZBd7ko3XTxdT dONZhhAM1Ww2vQF+rshUSJrSi7h+J3DWghGlYVBQxdgidDogObn9VUDy/ZRg9WaCjP6b me1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782431165; x=1783035965; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jnIzd9eXyM0lY5nLSKWOGJM4W2fxtczCL/IrCKu34m8=; b=fEHG+4x11KL/Z3GOd7sq2VvS9FjPy1rH6Sau0oBd5raK+nuz4o/rWiYdNPVh7NBIOL 0jgfQy0NDuCoXncGRMAU8SFHzXfMtcQKum7acISZ/saHGae2xHjE5dQe3UH+fSAEF5o0 N5oLYLTt3fTV9Tj/35Bx47D7XdqGoVCiyKNetvbrnPBNm46nsgKa+SOAM5FpGeK5wBN+ 47znFwq28KI/y4ghD6abSckZ1vssMLHSoI/WGboNr75QcT6yjWwthgYRcsJye8DF6qdA D2eSKIuJP8QkYF+IRA6FOVNSpi9NKrpsHbaT3O255fBqxtRhGN2S8fsF4o7ooanfKTbS SBYg== X-Forwarded-Encrypted: i=1; AFNElJ+JRRrPt51+c8nohE/qwK5yCVhGKsrS5Qru6hZUhiOIEL6fhvQPBmrNEt2PCCKJo8RIxGOOdfWIRmgYORE=@vger.kernel.org X-Gm-Message-State: AOJu0YzhcF/+/VEfVZ445GVvJa703UI25GgSkYt8/Zv2dQluO9F4yWXp iDX6elTp44Hw2auB2wOb/MZbi1juDfl2qXuDhYZGGhuHeizTrYxsj+U= X-Gm-Gg: AfdE7cl5APrv+u8mdRHLIvA4gJzQx1T2n1ibq8WnEndtllbukAsZ+kR0zvUyodaaiCl 8bj7gLCdXSixcxIFkBmt+EigTTu42kLeeO0U64xZ35prZqaZR8PuHrpt2ImPQ6LllDWL42ovFPD CAuExdX6qfk5qs9qYivcaFuLKRgdE3dIzM1d33TARuvKqR90xyjXBJOt5lPn3zf8Pqf4xLU58gE WcoKNIH/WTHTJeokOKRgLyv38JGiPIOPWory7EAha27lu0/Q1EhMDZahufqHkDpruMXAkxxU41K PxVOwnVG33AykJTCivcUUBVpdquY7g08D1aIX9hGg4uKVBvvIL7TaHu8/NmE/1VXpyVhpClKcha Ql+yj4l8Vq2cAt2VGiSCRnWbWVsoZDnJbl7pdcFRYEaSdY1qPCWRvq3s= X-Received: by 2002:a05:600d:6452:10b0:492:1e36:85dc with SMTP id 5b1f17b1804b1-4926689ac37mr53156515e9.36.1782431164934; Thu, 25 Jun 2026 16:46:04 -0700 (PDT) Received: from debian ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46c22c680fasm20285246f8f.34.2026.06.25.16.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 16:46:04 -0700 (PDT) From: Tristan Madani To: Christian Lamparter Cc: Doruk Tan Ozturk , Johannes Berg , Jeff Johnson , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, tristan@talencesecurity.com Subject: Re: [PATCH] wifi: carl9170: clamp command response copy to the read buffer size Date: Thu, 25 Jun 2026 23:46:03 -0000 Message-ID: <178243116343.3635355.16109712055530784127@gmail.com> In-Reply-To: CAPdMp1oWXvtdvp8D0f32vpvzGa0H9PhprQcACqqoc4Gnyy=f6A@mail.gmail.com References: CAPdMp1oWXvtdvp8D0f32vpvzGa0H9PhprQcACqqoc4Gnyy=f6A@mail.gmail.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Christian, Doruk, No worries at all, these things happen. Both patches address the same underlying issue from different angles -- mine returns early after carl9170_restart() to skip the invalid response entirely, Doruk's clamps the memcpy to ar->readlen. Either approach works. If it helps, I'm happy to respin my 3-patch series (the other two patches fix the TX status off-by-two and rx_stream failover overflow in the same driver). Let me know if you'd prefer a fresh resend or if you'd rather pick from what's already on the list. Thanks, Tristan