From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 639283F9F4D; Fri, 26 Jun 2026 16:58:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782493116; cv=none; b=QrIIdpvdFqYU2AHl+98oS8yzaZUi99WZ4IWUGTsrUyFbGZkiKbXXfLMVD1aRSaL4t818Vn9QUTN+g3ut3W9PDK4tFRL04fBFSYPE6+DlJyKCLADnBuB8loEbg/Lzm0cnY2Yx2rxvkldFniuBwgqbFH8T2FDTQVsmi3iN5UEw/mM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782493116; c=relaxed/simple; bh=tctF25yDjX2h/D8jTaVAW8rgtRGo6jx+AhqWLDpBgto=; h=Content-Type:MIME-Version:In-Reply-To:References:Subject:From:Cc: To:Date:Message-ID; b=PBKTrt3jVWTfD9aXD1FN1++zvIOOvdN5rBph+7yEq/t5tJiS8l2tG6ZjlQxjtp+m0qeHqCyPsb9vRPY0g+ZVFa+tg34vFg2KGIk5d66vbmcXzTJrzgqKLDnY49piOENcz5fyx3q2fi7DAkXdzOqABNYH8jMfKSSq6tzpBg+0ghU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=fail (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=XavWwpTs reason="signature verification failed"; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="XavWwpTs" Received: from monstersaurus.ideasonboard.com (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D3CD91E7; Fri, 26 Jun 2026 18:57:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782493070; bh=tctF25yDjX2h/D8jTaVAW8rgtRGo6jx+AhqWLDpBgto=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=XavWwpTshvR2O36bfPMEeGMaH0w7ZdslrtG03Qazu+OZnaOrAdHxWil5SaIhIb0cY JMvAYnk+2anzMx7HlygYjieq5FydLfCQQ2JSjFiBcLiE61AZt31R9BdllD2TjmFZbd IcL7snuNtXIT11WheBb0ccOUTcoe4r1AFdHxHaok= Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20260626143310.GF2363897@killaraus.ideasonboard.com> References: <20260626-kbingham-orientation-v2-0-47178be927b4@ideasonboard.com> <20260626-kbingham-orientation-v2-4-47178be927b4@ideasonboard.com> <20260626143310.GF2363897@killaraus.ideasonboard.com> Subject: Re: [PATCH v2 4/8] ARM: tegra: Convert to new media orientation definitions From: Kieran Bingham Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jacopo Mondi , Sakari Ailus , Jimmy Su , Matthias Fend , Mikhail Rudenko , Daniel Scally , Jacopo Mondi , Michael Riesch , Benjamin Mugnier , Sylvain Petinot , Paul Elder , Martin Kepplinger , Quentin Schulz , Tommaso Merciai , Svyatoslav Ryhel , Richard Acayan , Thierry Reding , Jonathan Hunter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Bjorn Andersson , Konrad Dybcio , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux@ew.tq-group.com, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org To: Laurent Pinchart Date: Fri, 26 Jun 2026 17:58:28 +0100 Message-ID: <178249310801.36676.2030968701607803461@ping.linuxembedded.co.uk> User-Agent: alot/0.9.1 Quoting Laurent Pinchart (2026-06-26 15:33:10) > On Fri, Jun 26, 2026 at 01:07:56PM +0100, Kieran Bingham wrote: > > The orientation property for video interface devices now has definitions > > to prevent hardcoded integer values for the enum options. > >=20 > > Update the users throughout the nvidia device trees to use the new > > definitions. > >=20 > > Signed-off-by: Kieran Bingham > > --- > > arch/arm/boot/dts/nvidia/tegra30-asus-nexus7-grouper-common.dtsi | 3 += +- > > arch/arm/boot/dts/nvidia/tegra30-asus-transformer-common.dtsi | 3 += +- > > arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts | 4 += ++- > > arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi | 3 += +- > > 4 files changed, 9 insertions(+), 4 deletions(-) > >=20 > > diff --git a/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi b/arch/arm/boo= t/dts/nvidia/tegra30-lg-x3.dtsi > > index 60e8a19aa70e..c58e3026a115 100644 > > --- a/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi > > +++ b/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi > > @@ -4,6 +4,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > =20 > > @@ -1216,7 +1217,7 @@ rear-camera@10 { > > dvdd-supply =3D <&vdd_1v2_rear>; > > avdd-supply =3D <&vdd_2v7_rear>; > > =20 > > - orientation =3D <1>; /* Rear camera */ > > + orientation =3D ; >=20 It must have been hot when I typed that one out... > This should be MEDIA_ORIENTATION_BACK. And you should compile all the > device trees the series touch. Indeed, I got caught out by these being in arm, with the others in arm64 even though I explicitly pulled these out to a separate patch! Fixed up and now I have compiled also with: make O=3Darm32 ARCH=3Darm multi_v7_defconfig make O=3Darm32 ARCH=3Darm dtbs -j32 which looks clean. > Reviewed-by: Laurent Pinchart Thanks Kieran >=20 > > rotation =3D <90>; > > =20 > > nvmem =3D <&m24c08>; >=20 > --=20 > Regards, >=20 > Laurent Pinchart