From: Paul Mackerras <paulus@samba.org>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Clean up PPC code to use canonical alignment macros from kernel.h.
Date: Tue, 9 Jan 2007 08:27:02 +1100 [thread overview]
Message-ID: <17826.46886.680834.928790@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0701081535140.2965@localhost.localdomain>
Robert P. J. Day writes:
> Clean up some PowerPC source files to use the canonical alignment
> macros from kernel.h, and add an ALIGN_DOWN() macro to kernel.h for
> symmetry.
[snip]
> and, no, i didn't test-compile this as i don't have a PPC
> cross-compiler at the moment. sorry.
Yeah. I would be surprised if it did build, since you are removing
definitions without adding any #includes to make sure we get the
global definition.
> arch/powerpc/boot/addRamDisk.c | 3 +--
> arch/powerpc/boot/of.c | 2 +-
> arch/powerpc/boot/page.h | 9 +--------
> arch/powerpc/boot/simple_alloc.c | 8 ++++----
NAK. Stuff in arch/powerpc/boot intentionally *doesn't* depend on
Linux kernel headers, since it runs outside of the kernel, either on
the build machine (addRamDisk.c) or before the kernel.
Paul.
next prev parent reply other threads:[~2007-01-09 0:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-08 20:40 Robert P. J. Day
2007-01-08 21:27 ` Paul Mackerras [this message]
2007-01-09 0:21 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17826.46886.680834.928790@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®