From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DC8F3FB7F6; Tue, 30 Jun 2026 11:32:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782819154; cv=none; b=J/ECo8ADSK6nTlvGDSxbhihYOz3Q+m2XdIS2X/yP7HH9AonV2VYptlXtxyv50isguRZ+JgkpIguZXoNV52nySN3pY4PBwpV3CWWQCz8C9j7M69a7EZ8uhAxqVnfIZZotlSX90H9ktlc/V//j5GLoHmPR8jvmb4+dQee1q3QjPkw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782819154; c=relaxed/simple; bh=QYl8iPtWa4ZvMQkSXAhD1QI5wKvAQxLeSri7kGcL8Pk=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=Da9N2qsMOFIK59Vd+mTdSBm0RfeVhthr+lB9CsU/D0bSPtc1sIyYegTVEBDaFkKKmjj2fq6vpq6AO36C4rV7mxngZaSonW1L5P06aaSNgxeiBAv6mjkrqf1riXrRg6gm9PXQoUQb7095iULf8sWnUIuOn6nMq/moOaDv7ksQhu0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=MPpdWQlj; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=r089j5tx; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="MPpdWQlj"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="r089j5tx" Date: Tue, 30 Jun 2026 11:32:28 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1782819150; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D5DFyRQQTtpPbCun8swIxMr3MAbwkMcY9CPDAy/30xE=; b=MPpdWQljgL84AvggWZm3b8F+DaNy3gOFH32AScP1XBfEZ/uYd6bO45HB09fM7/JEgeHbW5 fCr9dV4iLFVgxZK+MMD6Cev1klPcemEmbtJ5Cb9k4nSVo70+BBeo61PYNYuqE/zjONt6Kb 5aublPM5o09RDasDO4sz9VH5c6v2l+heI+Ae30dbFlvVx4Wq9w4zLR8+FeuDqUKis+J+kR kBomkKNA8qepH8ts89nd5/w8kPXSyCNnWtSVzQQyoYcVE1bJIRBz4jNCIAjooe2TqufQ35 AksK3mVDjTn2Pqu/hFyXWhP+HjfIGxWLs6tX1koj3X2I0WSuTNVJ0tq0825U0A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1782819150; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D5DFyRQQTtpPbCun8swIxMr3MAbwkMcY9CPDAy/30xE=; b=r089j5txCrQqZIjInThoJd5wtFsRi78GzF6uuaUhPMNBGcgukx7rTfXZIvsGx6aG+b7L4D FOeh9JKC+Q08mnCQ== From: "tip-bot2 for Zhan Xusheng" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: sched/core] sched/fair: Fix stale comments referring to removed CFS concepts Cc: Zhan Xusheng , Ingo Molnar , Peter Zijlstra , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20260629030200.3165589-1-zhanxusheng@xiaomi.com> References: <20260629030200.3165589-1-zhanxusheng@xiaomi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <178281914880.3843924.9433276416273945943.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The following commit has been merged into the sched/core branch of tip: Commit-ID: 19b7bdc3a1550ab2550427c33395bec7caeaf72d Gitweb: https://git.kernel.org/tip/19b7bdc3a1550ab2550427c33395bec7cae= af72d Author: Zhan Xusheng AuthorDate: Mon, 29 Jun 2026 11:02:00 +08:00 Committer: Ingo Molnar CommitterDate: Tue, 30 Jun 2026 13:30:23 +02:00 sched/fair: Fix stale comments referring to removed CFS concepts A few comments still describe the pre-EEVDF CFS world: - sysctl_sched_base_slice is documented as "Minimal preemption granularity for CPU-bound tasks". That was the wording of the old sysctl_sched_min_granularity, renamed in commit e4ec3318a17f ("sched/debug: Rename sysctl_sched_min_granularity to sysctl_sched_base_slice"). Under EEVDF it is the default base time slice / request size (r_i) used to compute the virtual deadline, as documented in update_deadline(). - Two comments still mention sched_slice(), which was removed when the fair class committed to EEVDF in commit 5e963f2bd465 ("sched/fair: Commit to EEVDF"). The dequeue-path comment should simply refer to the task's slice (se->slice); the forced-idle comment describes the slice accounting now performed by __entity_slice_used(), which is the function actually used right below it. No functional changes. [ mingo: Ported to a more recent scheduler base ] Signed-off-by: Zhan Xusheng Signed-off-by: Ingo Molnar Cc: Peter Zijlstra Link: https://patch.msgid.link/20260629030200.3165589-1-zhanxusheng@xiaomi.com --- kernel/sched/fair.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index ce05acf..fc6cd55 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -73,7 +73,10 @@ unsigned int sysctl_sched_tunable_scaling =3D SCHED_TUNABLESCALING_LOG; =20 /* - * Minimal preemption granularity for CPU-bound tasks: + * Default base time slice (request size r_i) for SCHED_NORMAL/SCHED_BATCH: + * + * Under EEVDF this is the request size used to compute the virtual + * deadline; see update_deadline(). * * (default: 0.70 msec * (1 + ilog(ncpus)), units: nanoseconds) */ @@ -14676,7 +14679,7 @@ static inline void task_tick_core(struct rq *rq, stru= ct task_struct *curr) * if the sibling is forced idle, then trigger schedule to * give forced idle task a chance. * - * sched_slice() considers only this active rq and it gets the + * __entity_slice_used() considers only this active rq and it gets the * whole slice. But during force idle, we have siblings acting * like a single runqueue and hence we need to consider runnable * tasks on this CPU and the forced idle CPU. Ideally, we should