From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04AB7223DEA for ; Thu, 2 Jul 2026 01:07:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782954473; cv=none; b=Ed/7mVPhGT4LO4RrLCzP6hmhv3jeDmeff8sOy++CPXKvCcWCnaGYiyTI73a8GTSvEUuBF3SONS8wybAnP3ApgV2nVo3APbL+xtzRjCX/56nW/eajAmFUD4YdrhpWUsIGeViwYFXKZ3Fmzot0IeNSNP//OmT+4AuV8tTzsQwxUeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782954473; c=relaxed/simple; bh=v9Y+MRAzTZRAhDhvK2IbxvuPRET8FFXnOogEHx1gd/o=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=pSkZ52Oe68dD/637b91zTnqU6EGsdt7/kZnrOrOKYy+dJDzSyA3h1tuHKfZHMeoRMOTPoG2FPtEOs6YsxPOMmjbV34bRDWs0+Lj2NVsikw23m1mv7urlKqVH5jV3tL9DFkM4gMlSs2IZRVWlIU5idRlzp4YzFfKeeFLb48RU0os= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=GEXMZf4Q; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="GEXMZf4Q" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-7e9eaf04bfaso418097a34.1 for ; Wed, 01 Jul 2026 18:07:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1782954471; x=1783559271; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U9k3PRJQnpDO0neh6CEM6x4TZ6ua/bi9KKsm/tK+P+I=; b=GEXMZf4QfLeNEgLDzYFuTz3bQa27K8k0f2AqgUMp/Qkujo6axyKk3lxmtxXVOMDeLm XONAVktPFkQIntHFpBcQiV5w1mVx7fOiII9m/YQU9EzK9pBjWexiPwcYX3JN0Y7rQarx SngjXWj6cu4Pr/OCjrMt0wyvIoJpkWk2H8LiDDgatjnIajsx0llYzCBF71E12bbJo3CF Y2IkZFC1U2eDR/gxTbWO8KFMmgc7pT+KWAURxFR3QhFOiDYo83dyDSmO3fzdhxyXQOqR StljF+D7gz3+X5YmMvBynf16OFGnV4NTzqszIQldRzeSHhR5MKz6IF4m3TDuLQX988y1 dHHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782954471; x=1783559271; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U9k3PRJQnpDO0neh6CEM6x4TZ6ua/bi9KKsm/tK+P+I=; b=MA7wuVnPXXATkG5owvsEW4f+ROhG3fwLu8Gpue+OHgBHcpEgj35Ms+ex+29l/iZM+a 6rgvjoY/xNmKXibzPXHnxgtwXjGEzNUm7BnQNUgMPLYoejCkb0mj/fuWflzmN23d3FP1 CqNQrfQHiRrlkPghNlMt/dNRzB27LrhNCjfjPBuWZRQ7HvPFp/ltat+hE9VczEUL2QKx swnTChOwikckCwlTxqCKU8xC5I6kGSSxWYCJjYNyKZOp+4BZs4lUkzAEXAROeu/wrxL2 sUpbb6+5XSxNFOsOCLjwTE+3XaYmxjR6UqaotHT/tMe6xb2Urge7pO7Rl6r++b7nx176 7FFw== X-Forwarded-Encrypted: i=1; AFNElJ/gViYbp7lY+5vfShPTO3P/6hGme4hRvgnNwkifzuZffm1SnMWa5WuTERSb0ehEHF7IGxffrI8KYptrDxk=@vger.kernel.org X-Gm-Message-State: AOJu0YxI4vXskHw0ByZkLWlA/6x4C2fVMMo88dPsjccX1ijZ+4UkZF0h 49/B0o4fITsbVw9y9BtTEZsqWRympEWjWk3N+0B2qnVa6pvh1mtcP3E0nZtHPCmdyKTCY1iT7hY c/znHrVo= X-Gm-Gg: AfdE7ckOnOjraVSSrvL1l+vTYyXQ5Sa6TJE+m9N1rA1iMbr1ZbiPH786n3JIIfQthTj VwEpxP4lgdwlqBsYq8wEsk9qHgYJlZ3IdPreCVM7QMrsqcHdLR7K+f2pse37BkYwXc6g4j/mTMv yE/6X0rXibP/gtcgVCl8JYv6c3SDH64R9GsDOlDa/sAm37AGYTWYx0TorPpeFkHp+Czu0RGUfU1 LZR42pwjDM7/qjnDe3GVqzccBnYftxcUrTxyK9fDW4CK7JHc9SRLeP9Z3X8vyzgnoaRLuPSMdTG GBUg8TdB07FLgBP812RSsrmaYOvx6pQNaD6beoYEjom3aN+f7B+G7Xbx0jRnTbn2ZRViOdMr7UH atWDNI0aQlX9QtQMJaBylOFRZndAfrx6X2zyniLSUBShVfIOGe435pcPlLacQxtzmzIg9MA1atW Qr9ZeKQNo7c64D2D6Ra21r1tq08xPOrmkO1pA8DMLotDgA4U7/NadxnA5MhVT6PNkhTg== X-Received: by 2002:a05:6830:3744:b0:7e6:ee1f:96f1 with SMTP id 46e09a7af769-7eb48aaebcfmr2445572a34.5.1782954470740; Wed, 01 Jul 2026 18:07:50 -0700 (PDT) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7eb542cadeasm1428514a34.7.2026.07.01.18.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 18:07:49 -0700 (PDT) From: Jens Axboe To: guzebing Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20260621014030.1625306-1-guzebing1612@gmail.com> References: <20260621014030.1625306-1-guzebing1612@gmail.com> Subject: Re: [PATCH] block: Make WBT latency writes honor enable state Message-Id: <178295446925.50965.1910380292736043449.b4-ty@b4> Date: Wed, 01 Jul 2026 19:07:49 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.15.2 On Sun, 21 Jun 2026 09:40:30 +0800, guzebing wrote: > queue/wbt_lat_usec controls both the stored WBT latency target and the > effective WBT enable state. > > The old no-op check skipped updates whenever the converted latency > matched the stored min_lat_nsec. That check ignored whether the current > WBT state already matched the state requested by the write. For a queue > disabled by default, attempting to enable WBT by writing the default > value through sysfs could return success while the enable state was left > unchanged. > > [...] Applied, thanks! [1/1] block: Make WBT latency writes honor enable state commit: 1e56f30a73f304fe26a272742c398aedd88a1a6c Best regards, -- Jens Axboe