From: "tip-bot2 for Hisam Mehboob" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Hisam Mehboob <hisamshar@gmail.com>,
Thomas Gleixner <tglx@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: locking/futex] selftests/rseq: Replace glibc-specific __GNUC_PREREQ with portable check
Date: Thu, 02 Jul 2026 22:19:38 -0000 [thread overview]
Message-ID: <178303077880.3843924.3398329165284401118.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260618193724.589113-2-hisamshar@gmail.com>
The following commit has been merged into the locking/futex branch of tip:
Commit-ID: d7b2769f8dba3e5f40d2a8a11988812d51160b17
Gitweb: https://git.kernel.org/tip/d7b2769f8dba3e5f40d2a8a11988812d51160b17
Author: Hisam Mehboob <hisamshar@gmail.com>
AuthorDate: Fri, 19 Jun 2026 00:37:25 +05:00
Committer: Thomas Gleixner <tglx@kernel.org>
CommitterDate: Fri, 03 Jul 2026 00:15:01 +02:00
selftests/rseq: Replace glibc-specific __GNUC_PREREQ with portable check
Building the rseq selftests against musl libc fails because musl's
<features.h> does not provide the glibc-specific __GNUC_PREREQ macro:
error: missing binary operator before token '('
Replace __GNUC_PREREQ(11, 1) with an equivalent check using __GNUC__
and __GNUC_MINOR__ directly. This pattern is portable across all C
library implementations and is already used elsewhere in the tools/
tree (e.g., tools/include/linux/string.h).
This also allows removing the #include <features.h>, which was only
needed for __GNUC_PREREQ.
Fixes: 886ddfba933f ("selftests/rseq: Introduce thread pointer getters")
Signed-off-by: Hisam Mehboob <hisamshar@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260618193724.589113-2-hisamshar@gmail.com
---
tools/testing/selftests/rseq/rseq-x86-thread-pointer.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/testing/selftests/rseq/rseq-x86-thread-pointer.h b/tools/testing/selftests/rseq/rseq-x86-thread-pointer.h
index d313358..5a29d6b 100644
--- a/tools/testing/selftests/rseq/rseq-x86-thread-pointer.h
+++ b/tools/testing/selftests/rseq/rseq-x86-thread-pointer.h
@@ -8,13 +8,11 @@
#ifndef _RSEQ_X86_THREAD_POINTER
#define _RSEQ_X86_THREAD_POINTER
-#include <features.h>
-
#ifdef __cplusplus
extern "C" {
#endif
-#if __GNUC_PREREQ (11, 1)
+#if __GNUC__ > 11 || (__GNUC__ == 11 && __GNUC_MINOR__ >= 1)
static inline void *rseq_thread_pointer(void)
{
return __builtin_thread_pointer();
prev parent reply other threads:[~2026-07-02 22:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 19:37 [PATCH] " Hisam Mehboob
2026-07-02 22:19 ` tip-bot2 for Hisam Mehboob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178303077880.3843924.3398329165284401118.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=hisamshar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®